Skip to content

UPSTREAM: arm64: dts: qcom: monaco: Remove the little/big_cpu_sleep_0 idle states - #989

Open
navya-malempati wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
navya-malempati:qcs8300-6.18y-cpu-sleep-idle
Open

UPSTREAM: arm64: dts: qcom: monaco: Remove the little/big_cpu_sleep_0 idle states#989
navya-malempati wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
navya-malempati:qcs8300-6.18y-cpu-sleep-idle

Conversation

@navya-malempati

@navya-malempati navya-malempati commented Aug 20, 2026

Copy link
Copy Markdown

Firmware supports both CPU power collapse (little/big_cpu_sleep_0) and
CPU PLL/rail power collapse (little/big_cpu_sleep_1) idle states.
However, CPU power collapse modes are often not utilized in favor of
performance, so remove the CPU power collapse modes for monaco,
aligning with SM8350/SM8450/SM8550/SM8650.

Rename little/big_cpu_sleep_1 as little/big_cpu_sleep_0 since it is now
the only CPU idle state in use.

CRs-Fixed: 4654990

Signed-off-by: Navya Malempati navya.malempati@oss.qualcomm.com
Reviewed-by: Maulik Shah maulik.shah@oss.qualcomm.com
Link: https://lore.kernel.org/r/20260522-ml_cpuidle-v1-1-fd311cf33fb4@oss.qualcomm.com
Signed-off-by: Bjorn Andersson andersson@kernel.org

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

3 similar comments
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

… idle states

Firmware supports both CPU power collapse (little/big_cpu_sleep_0) and
CPU PLL/rail power collapse (little/big_cpu_sleep_1) idle states.
However, CPU power collapse modes are often not utilized in favor of
performance, so remove the CPU power collapse modes for monaco,
aligning with SM8350/SM8450/SM8550/SM8650.

Rename little/big_cpu_sleep_1 as little/big_cpu_sleep_0 since it is now
the only CPU idle state in use.

Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>
Reviewed-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260522-ml_cpuidle-v1-1-fd311cf33fb4@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
@navya-malempati
navya-malempati force-pushed the qcs8300-6.18y-cpu-sleep-idle branch from 8cf8e1e to ae8d44e Compare August 20, 2026 07:10
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@navya-malempati navya-malempati changed the title arm64: dts: qcom: monaco: Remove the little/big_cpu_sleep_0 idle states UPSTREAM: arm64: dts: qcom: monaco: Remove the little/big_cpu_sleep_0 idle states Aug 20, 2026
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4654990 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4654990
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

Copy link
Copy Markdown

PR #989 — validate-patch

PR: #989

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes - https://lore.kernel.org/r/20260522-ml_cpuidle-v1-1-fd311cf33fb4@oss.qualcomm.com correctly referenced in Link: trailer
  2. Lore link matches PR commits: Yes - commit message body, subject (minus UPSTREAM: prefix), and diff content are identical to the lore patch
  3. Upstream patch status: ✅ ACKed - merged as 00dd037fc31452962eba38cdb46feafb0b70d96e in Bjorn Andersson's tree on July 8, 2026. Maintainer reply: "Applied, thanks!" with commit SHA. Also received Reviewed-by: Maulik Shah on June 5, 2026.
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #989 - UPSTREAM: arm64: dts: qcom: monaco: Remove the little/big_cpu_sleep_0 idle states
Upstream commit: https://lore.kernel.org/r/20260522-ml_cpuidle-v1-1-fd311cf33fb4@oss.qualcomm.com
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream Subject faithfully preserved with UPSTREAM: prefix added
Body preserves rationale Commit body identical to lore patch - explains firmware support, performance rationale, and alignment with SM8350/SM8450/SM8550/SM8650
Fixes tag present/correct N/A No Fixes tag in upstream or PR (not a bug fix)
Authorship preserved From: matches lore author (Navya Malempati)
Backport note (if applicable) N/A Not a backport - marked as UPSTREAM: with maintainer's Signed-off-by: present

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco.dtsi Diff content identical to lore patch - removes little/big_cpu_sleep_0 idle states, renames _sleep_1 to _sleep_0, updates domain-idle-states references

Issues

None - patch is a faithful representation of the upstream commit.

Verdict

Merge as-is. The PR commit is an accurate representation of the upstream patch that was accepted and merged by maintainer Bjorn Andersson on July 8, 2026 as commit 00dd037fc31452962eba38cdb46feafb0b70d96e.

Final Summary

  1. Lore link present: Yes - https://lore.kernel.org/r/20260522-ml_cpuidle-v1-1-fd311cf33fb4@oss.qualcomm.com correctly referenced in Link: trailer
  2. Lore link matches PR commits: Yes - commit message body, subject (minus UPSTREAM: prefix), and diff content are identical to the lore patch
  3. Upstream patch status: ✅ ACKed - merged as 00dd037fc31452962eba38cdb46feafb0b70d96e in Bjorn Andersson's tree on July 8, 2026. Maintainer reply: "Applied, thanks!" with commit SHA. Also received Reviewed-by: Maulik Shah on June 5, 2026.
  4. PR present in qcom-next/topics: Yes - integration_presence_report.md confirms exact patch-id match at 00dd037fc31452962eba38cdb46feafb0b70d96e in topics

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 3c1e80ceb9fb6978aa94bc0624e7c0003f3b4f6e
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] UPSTREAM: arm64: dts: qcom: monaco: Remove the missing - no subject, patch-id, or full tree-content match found present - exact patch-id match at 00dd037 present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

Copy link
Copy Markdown

PR #989 — checker-log-analyzer

PR: #989
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32340113039

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check All DTB validations passed
sparse-check ⏭️ Skipped - no C/H file changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance Missing subject prefix
tag-check Missing subject prefix (mandatory for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #989 - UPSTREAM: arm64: dts: qcom: monaco: Remove the little/big_cpu_sleep_0 idle states
Target branch: qcom-6.18.y
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32340113039

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check All DTB validations passed
sparse-check ⏭️ Skipped - no C/H file changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance Missing subject prefix
tag-check Missing subject prefix (mandatory for qcom-6.18.y)

❌ check-patch-compliance

Root cause: The commit subject line does not start with a required prefix tag.

Failure details:

Checking commit: arm64: dts: qcom: monaco: Remove the little/big_cpu_sleep_0 idle states
Commit summary does not start with a required prefix

The commit message in the PR branch is missing the UPSTREAM: prefix. While the patch file format (.patch) includes UPSTREAM: in the Subject header, the actual git commit message does not have this prefix.

Fix:

Amend the commit to add the UPSTREAM: prefix to the subject line:

git rebase -i d1996e72bb5d27f7f7a4920f5cc7b0ca0dba463c  # mark commit as 'edit'
git commit --amend -m "UPSTREAM: arm64: dts: qcom: monaco: Remove the little/big_cpu_sleep_0 idle states

Firmware supports both CPU power collapse (little/big_cpu_sleep_0) and
CPU PLL/rail power collapse (little/big_cpu_sleep_1) idle states.
However, CPU power collapse modes are often not utilized in favor of
performance, so remove the CPU power collapse modes for monaco,
aligning with SM8350/SM8450/SM8550/SM8650.

Rename little/big_cpu_sleep_1 as little/big_cpu_sleep_0 since it is now
the only CPU idle state in use.

Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>
Reviewed-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260522-ml_cpuidle-v1-1-fd311cf33fb4@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>"

git rebase --continue
git push --force-with-lease

Reproduce locally:

cd /path/to/kernel
git log d1996e72bb5d..8cf8e1efab10 --format="%H %s" | \
  grep -vE '^[a-f0-9]+ (FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'

❌ tag-check

Root cause: Subject prefix is mandatory for all branches except qcom-next and qcom-next-staging; this PR targets qcom-6.18.y.

Failure details:

The PR targets qcom-6.18.y, which requires every commit to have a subject-line prefix tag. The commit:

8cf8e1efab100b963053eb7c9529fd2eacd2e1e0 "arm64: dts: qcom: monaco: Remove the little/big_cpu_sleep_0 idle states"

does not start with any of the required prefixes:

  • FROMLIST: - Patch posted to mailing list
  • FROMGIT: - Patch from maintainer tree
  • UPSTREAM: - Patch merged into mainline ✅ (correct choice for this commit)
  • BACKPORT: - Backported with modifications
  • QCLINUX: - Vendor-only change
  • PENDING: - Work-in-progress
  • WORKAROUND: - Temporary fix

Fix:

Same as check-patch-compliance above - add UPSTREAM: prefix to the commit subject.

Note: The patch has a valid Link: tag pointing to lore.kernel.org and was signed off by Bjorn Andersson (maintainer), confirming this is an upstream-merged patch. The UPSTREAM: prefix is the correct choice.


Verdict

1 blocker must be fixed before merge:

The commit subject line must be amended to include the UPSTREAM: prefix. This is required by both check-patch-compliance and the mandatory tag-check for the qcom-6.18.y target branch.

All other checkers passed or correctly skipped. Once the prefix is added and the PR is force-pushed, re-trigger CI to verify the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants