chore(ci): update release process according to new Quarkiverse process #977
Conversation
Signed-off-by: Chris Laprun <claprun@redhat.com>
|
Don't forget to delete https://github.com/quarkiverse/quarkus-operator-sdk/blob/main/.github/workflows/release.yml in this PR too |
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
| fi | ||
|
|
||
| git checkout -b release | ||
| ./mvnw -B release:prepare -Prelease -Darguments="-DperformRelease -Dno-samples -DskipTests" -DreleaseVersion=${{steps.metadata.outputs.current-version}} -DdevelopmentVersion=${{steps.metadata.outputs.next-version}} |
There was a problem hiding this comment.
I see you're passing a -Dno-samples here, which is not done in the reusable workflow. Can you define it in a Maven profile?
There was a problem hiding this comment.
It is already defined in a no-samples profile but for some reason that I don't recall I activated the profile via the property instead of using it directly… 🤔
There was a problem hiding this comment.
Though that raises an interesting question that I hadn't paid attention to, indeed. How can I not release my samples with this new process?
There was a problem hiding this comment.
There was a problem hiding this comment.
Hmm, though that means I need another profile to deactivate based on the property…
There was a problem hiding this comment.
According to https://maven.apache.org/guides/introduction/introduction-to-profiles.html#multiple-conditions, you can specify more than one activation. Plus you can also specify !true to match when the system property "no-docs" is not defined, or is defined with a value which is not "true" in the no-* properties you already have:
<profile>
<id>no-docs</id>
<activation>
<property>
<name>no-docs</name>
<value>!true</value>
</property>
<property>
<name>performRelease</name>
<value>!true</value>
</property>
</activation>
<modules>
<module>docs</module>
</modules>
</profile>There was a problem hiding this comment.
IDEA doesn't agree that you can specify multiple properties. Also, the semantics is supposed to be AND, which isn't what I would like (OR semantics).
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun claprun@redhat.com