Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate OpenTelemetry to the WebSockets Next extension #41956

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jul 17, 2024

OTel part of the : #39143

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@michalvavrik
Copy link
Member Author

Crickey, I just mentioned that #39143 (comment) wants messages per connection and destination. Missed it till now. I'll make this draft and try to address it ASAP.

@michalvavrik michalvavrik marked this pull request as draft July 17, 2024 16:31
@michalvavrik michalvavrik marked this pull request as ready for review July 20, 2024 20:26
@michalvavrik
Copy link
Member Author

I think this is ready for review.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/ws-next-otel branch 2 times, most recently from 7c325ce to 22b00b4 Compare July 21, 2024 09:28
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@brunobat
Copy link
Contributor

Checking out the PR and Reviewing now... Will take some time. It's a biggie :)

@quarkus-bot

This comment has been minimized.

@michalvavrik
Copy link
Member Author

@mkouba @brunobat I believe I have addressed all your requests / comments and this PR is ready for a next round of reviews

@michalvavrik michalvavrik force-pushed the feature/ws-next-otel branch 2 times, most recently from a01b3d2 to fc21e37 Compare July 25, 2024 15:42
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 8, 2024

@mkouba we are close to the cut-off for features that will be in 3.14 and 3.15 LTS. So if you want this in, we will have to merge it very very soon as in before next Tuesday :).

@mkouba
Copy link
Contributor

mkouba commented Aug 8, 2024

@mkouba we are close to the cut-off for features that will be in 3.14 and 3.15 LTS. So if you want this in, we will have to merge it very very soon as in before next Tuesday :).

@gsmet I'm pretty sure we won't make it :-(

This is a massive PR that needs a detailed review. I will meet with Michal by the end of August.

@brunobat
Copy link
Contributor

@mkouba we are close to the cut-off for features that will be in 3.14 and 3.15 LTS. So if you want this in, we will have to merge it very very soon as in before next Tuesday :).

@gsmet I'm pretty sure we won't make it :-(

This is a massive PR that needs a detailed review. I will meet with Michal by the end of August.

Please include me.

@michalvavrik
Copy link
Member Author

Rebased on current main as this was pretty old now.

@quarkus-bot

This comment has been minimized.

Copy link

github-actions bot commented Aug 27, 2024

🎊 PR Preview 5588577 has been successfully built and deployed to https://quarkus-pr-main-41956-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot

This comment has been minimized.

@michalvavrik
Copy link
Member Author

I'll just rebase this on current main, no changes.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@michalvavrik michalvavrik changed the title Integrate Micrometer and OpenTelemetry to the WebSockets Next extension Integrate OpenTelemetry to the WebSockets Next extension Oct 22, 2024
@michalvavrik
Copy link
Member Author

michalvavrik commented Oct 22, 2024

Hello @mkouba @brunobat , you said this PR was too big, so I dropped Micrometer portion. Though there is some level of abstraction that I would probably leave out if I didn't know I need it for metrics. Please review when the time is right for you. I hope to open Micrometer PR once this is merged.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@michalvavrik
Copy link
Member Author

documentation build failure is not related, I think it is consequence of #42157 @radcortez @gsmet

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 22, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fb05551.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 22, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit fb05551.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

5 participants