Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump org.htmlunit to 4.5.0 #44017

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −10
Open

Bump org.htmlunit to 4.5.0 #44017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<jandex-gradle-plugin.version>1.0.0</jandex-gradle-plugin.version>

<asciidoctorj.version>2.5.13</asciidoctorj.version>
<htmlunit.version>4.3.0</htmlunit.version>
<htmlunit.version>4.5.0</htmlunit.version>
<javaparser-core.version>3.26.2</javaparser-core.version>
<jdeparser.version>2.0.3.Final</jdeparser.version>
<subethasmtp.version>6.0.1</subethasmtp.version>
Expand Down
8 changes: 5 additions & 3 deletions .../oidc-wiremock-logout/src/test/java/io/quarkus/it/keycloak/CodeFlowAuthorizationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
package io.quarkus.it.keycloak;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;

import java.io.IOException;
import java.net.URI;

import org.hamcrest.Matchers;
import org.htmlunit.SilentCssErrorHandler;
import org.htmlunit.TextPage;
import org.htmlunit.WebClient;
Expand Down Expand Up @@ -37,13 +39,13 @@ public void testCodeFlowFormPostAndBackChannelLogout() throws IOException {
form.getInputByName("username").type("alice");
form.getInputByName("password").type("alice");

TextPage textPage = form.getInputByValue("login").click();
HtmlPage afterClick = form.getInputByValue("login").click();

assertEquals("alice", textPage.getContent());
assertThat(afterClick.getWebResponse().getContentAsString(), Matchers.containsString("Submit This Form"));

assertNotNull(getSessionCookie(webClient, "code-flow-form-post"));

textPage = webClient.getPage("http://localhost:8081/service/code-flow-form-post");
TextPage textPage = webClient.getPage("http://localhost:8081/service/code-flow-form-post");
assertEquals("alice", textPage.getContent());

// Session is still active
Expand Down
13 changes: 7 additions & 6 deletions ...n-tests/oidc-wiremock/src/test/java/io/quarkus/it/keycloak/CodeFlowAuthorizationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo;
import static com.github.tomakehurst.wiremock.client.WireMock.urlPathMatching;
import static org.awaitility.Awaitility.given;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
Expand Down Expand Up @@ -219,13 +220,13 @@ public void testCodeFlowFormPostAndBackChannelLogout() throws IOException {
form.getInputByName("username").type("alice");
form.getInputByName("password").type("alice");

TextPage textPage = form.getInputByValue("login").click();
HtmlPage afterClick = form.getInputByValue("login").click();

assertEquals("alice", textPage.getContent());
assertThat(afterClick.getWebResponse().getContentAsString(), Matchers.containsString("Submit This Form"));

assertNotNull(getSessionCookie(webClient, "code-flow-form-post"));

textPage = webClient.getPage("http://localhost:8081/code-flow-form-post");
TextPage textPage = webClient.getPage("http://localhost:8081/code-flow-form-post");
assertEquals("alice", textPage.getContent());

// Session is still active
Expand Down Expand Up @@ -278,13 +279,13 @@ public void testCodeFlowFormPostAndFrontChannelLogout() throws Exception {
form.getInputByName("username").type("alice");
form.getInputByName("password").type("alice");

TextPage textPage = form.getInputByValue("login").click();
HtmlPage afterClick = form.getInputByValue("login").click();

assertEquals("alice", textPage.getContent());
assertThat(afterClick.getWebResponse().getContentAsString(), Matchers.containsString("Submit This Form"));

assertNotNull(getSessionCookie(webClient, "code-flow-form-post"));

textPage = webClient.getPage("http://localhost:8081/code-flow-form-post");
TextPage textPage = webClient.getPage("http://localhost:8081/code-flow-form-post");
assertEquals("alice", textPage.getContent());

// Session is still active
Expand Down