Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Cliffy commands to clipanion #11325

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

winniehell
Copy link
Contributor

@winniehell winniehell commented Nov 6, 2024

Description

Replaces all uses of cliffy/command with clipanion.

I would like to apologize because this refactoring became huge. But given that the APIs of the libraries are very different, I don't know a good way to split this.

part of #10878

migrating cliffy/prompt and cliffy/table will happen in separate pull requests.

Checklist

I have (if applicable):

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog in the PR
  • ensured the present test suite passes
  • added new tests
  • created a separate documentation PR in Quarto's website repo and linked it to this PR

@winniehell
Copy link
Contributor Author

npm imports are not supported by deno bundle, so this is blocked by #4955

@cscheid
Copy link
Collaborator

cscheid commented Nov 6, 2024

I appreciate the large PR, truly. But let me be frank - we're unlikely to be able to take this any time in the near future, precisely because the changes are so extensive.

@winniehell
Copy link
Contributor Author

winniehell commented Nov 6, 2024

sure, let me know if there is anything I can do to assist in the review process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants