-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Cliffy commands to clipanion #11325
Open
winniehell
wants to merge
43
commits into
quarto-dev:main
Choose a base branch
from
winniehell:cliffy-to-clipanion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winniehell
force-pushed
the
cliffy-to-clipanion
branch
from
November 6, 2024 16:03
e184300
to
7a99a2a
Compare
…ommand from cliffy to clipanion
winniehell
force-pushed
the
cliffy-to-clipanion
branch
from
November 6, 2024 16:07
7a99a2a
to
3adc7b3
Compare
npm imports are not supported by |
I appreciate the large PR, truly. But let me be frank - we're unlikely to be able to take this any time in the near future, precisely because the changes are so extensive. |
sure, let me know if there is anything I can do to assist in the review process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces all uses of cliffy/command with clipanion.
I would like to apologize because this refactoring became huge. But given that the APIs of the libraries are very different, I don't know a good way to split this.
part of #10878
migrating cliffy/prompt and cliffy/table will happen in separate pull requests.
Checklist
I have (if applicable):