Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle duplicate bot usernames with an error message instead of a 500 #206

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Handle duplicate bot usernames with an error message instead of a 500 #206

merged 1 commit into from
Oct 19, 2021

Conversation

0xAda
Copy link
Contributor

@0xAda 0xAda commented Oct 18, 2021 •
edited
Loading

Fixes #194

RACTFBot
RACTFBot approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@RACTFBot RACTFBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Auto-approved due to hotfix/ branch.

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #206 (5d17c9d) into master (d7ec3ae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   94.34%   94.35%           
=======================================
  Files         107      107           
  Lines        4671     4679    +8     
  Branches      269      269           
=======================================
+ Hits         4407     4415    +8     
  Misses        221      221           
  Partials       43       43
Impacted Files Coverage Δ
src/authentication/tests.py 100.00% <100.00%> (ø)
src/authentication/views.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7ec3ae...5d17c9d. Read the comment docs.

jchristgit
jchristgit approved these changes Oct 19, 2021
View reviewed changes
Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@thebeanogamer thebeanogamer merged commit 5434293 into master Oct 19, 2021
@thebeanogamer thebeanogamer deleted the hotfix/bot-usernames branch October 19, 2021 15:02
0xAda added a commit that referenced this pull request Sep 26, 2024
@0xAda
Handle duplicate bot usernames with an error message instead of a 500 (…
da2c120 
…#206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebeanogamer thebeanogamer thebeanogamer approved these changes

@jchristgit jchristgit jchristgit approved these changes

@RACTFBot RACTFBot RACTFBot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate Bot Username Not Handled
4 participants
@0xAda @thebeanogamer @jchristgit @RACTFBot