Combined pull request #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
May 29, 2019 21:59
… OpenStreetMapPrivateProvider (from kd7mrx)
…h OpenStreetMap policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request incorporates my own changes and those from several other contributors:
Corrected map name OpenStreetOsmProvider => OpenCycleMapProvider in Testing/Demo.Docking so the UI matches what the code is doing.
Corrected spelling of 'Sattelite' to 'Satellite' throughout. This affects the names shown in the Demo UIs and also any client which currently selects the OpenStreetMapQuestSatteliteProvider (sic) at initialization but improves consistency in the code and UI for the future.
Incorporated the (very nice!) OpenStreetMapCustomProvider from JusteBlanc.
Add an AddProvider interface in GMap.Providers so that applications can create their own private map provider classes and incorporate them at runtime without having to recompile the GMap.NET sources. I added lines to Demo.WindowsForms and Demo.WindowsPresentation that instantiate a new provider (named "OpenStreetMapPrivateProvider") that's pointed to my local tile server as an example.
Changed "http:" to "https:" requests throughout OpenStreetMapProvider and its derivatives.
Removed the dummy HTTP Referer header that was causing problems with OpenStreetMap's servers.
Incorporated dwcullop's BuildInfo tool as a submodule and use it to construct a valid UserAgent string that identifies Gmap.NET.Core with the build version and date as the client making the request.
I realize this is a big bundle of mostly unrelated changes and therefore somewhat hard to review. Changes #1, #2, the AddProvider method from #4 and changes #5, #6 and #7 are visible as individual commits on my branch. Change #3 is merged directly from JusteBlanc's fork.