Skip to content

Rename the currency check to git-clean - #17

Merged
thedavidmeister merged 1 commit into
mainfrom
git-clean-15
Aug 27, 2026
Merged

Rename the currency check to git-clean#17
thedavidmeister merged 1 commit into
mainfrom
git-clean-15

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Closes #15

Standardises the currency check on git-clean, all three names:

before after
file .github/workflows/copy-artifacts.yaml .github/workflows/git-clean.yaml
workflow name: copy-artifacts Git is clean
job id copy-artifacts git-clean

Unchanged: rainlanguage/rainix/.github/workflows/rainix-copy-artifacts.yaml@main
in the uses: line. rainix defines that reusable rather than consuming it, and
renaming it would break every consumer.

What the check context actually reads

Verified on this PR's live check list rather than assumed. Because this workflow calls a
reusable, GitHub names the check run <caller job id> / <reusable job id>, so the context is:

  • before: copy-artifacts / copy-artifacts
  • after: git-clean / copy-artifacts

The trailing copy-artifacts is the job id inside
rainix/.github/workflows/rainix-copy-artifacts.yaml, not anything this repo controls. This PR
does everything a consumer repo can do; the remaining half is a one-line job-id rename in rainix
itself. That rename would not break any uses: line — uses: resolves the workflow file, not a
job id — but it would change the context on every consumer at once, including this repo's required
one, so it belongs in its own rainix change rather than here.

The fully-conformant repos (rain.solver, rain.uniswap) show a bare git-clean because they
hand-roll their steps instead of calling the reusable.

Branch protection — action needed by an owner at merge time

This repo is the one that does require the old context. The main ruleset
(id 21201675) lists copy-artifacts / copy-artifacts under required_status_checks. This PR
changes the context this repo produces to git-clean / copy-artifacts, so on merge the required
context stops matching anything that runs and the check becomes silently no longer required
until the rule is updated.

Not changed here — a branch protection rule is not this PR's to edit. An owner should update the
ruleset entry from copy-artifacts / copy-artifacts to git-clean / copy-artifacts. The other
seven required contexts (rainix-sol / *, rs-static, rs-test, rs-wasm) are untouched.

Note the ordering hazard: while this PR is open it produces git-clean / copy-artifacts and not
copy-artifacts / copy-artifacts, so this PR itself cannot satisfy its own required context
merging it needs either the ruleset updated first or an admin merge.

QA

  • Discriminating tests: n/a — the diff is a CI workflow rename; there is no repo test that
    asserts a workflow's own name. The discriminating evidence is this PR's own check list: the job
    must appear with a git-clean caller segment and must not appear as
    copy-artifacts / copy-artifacts. Verified on the pushed head: it reads
    git-clean / copy-artifacts.
  • Mutations applied: n/a — no executable line changed. The one semantic hazard a mutation would
    probe (breaking the uses: line) is instead guarded by leaving that line byte-identical; grep
    over the diff confirms rainix-copy-artifacts.yaml@main is untouched.
  • Oracle: Standardise the currency check on git-clean (file, workflow name and job id) #15 states the target triple (file git-clean.yaml, name: Git is clean, job id
    git-clean), independently confirmed against the two already-conformant repos,
    rainlanguage/rain.solver and rainlanguage/rain.uniswap. The required-context finding is read
    from the live ruleset via the API, not from the issue, which had assumed no protection here.
  • Category check: the issue asks for three renames (file, workflow name, job id) and a
    branch-protection check before renaming; all four covered, and the protection check turned up a
    real required context, reported above rather than edited.

File, workflow name and job id all read copy-artifacts here. Standardise
on git-clean so the job id a reviewer reads in the checks list is the same
identifier in every repo. The rainix reusable it calls is unchanged.

Closes #15
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 49 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7da03e5a-5aa5-485d-8389-9ff9b432ec73

📥 Commits

Reviewing files that changed from the base of the PR and between 27960f0 and 6c5bc92.

📒 Files selected for processing (1)
  • .github/workflows/git-clean.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister
thedavidmeister merged commit 2edfbe0 into main Aug 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardise the currency check on git-clean (file, workflow name and job id)

1 participant