Rename the currency check to git-clean - #17
Merged
Merged
Conversation
File, workflow name and job id all read copy-artifacts here. Standardise on git-clean so the job id a reviewer reads in the checks list is the same identifier in every repo. The rainix reusable it calls is unchanged. Closes #15
|
Warning Review limit reachedNext included review available in 49 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
Standardises the currency check on
git-clean, all three names:.github/workflows/copy-artifacts.yaml.github/workflows/git-clean.yamlname:copy-artifactsGit is cleancopy-artifactsgit-cleanUnchanged:
rainlanguage/rainix/.github/workflows/rainix-copy-artifacts.yaml@mainin the
uses:line. rainix defines that reusable rather than consuming it, andrenaming it would break every consumer.
What the check context actually reads
Verified on this PR's live check list rather than assumed. Because this workflow calls a
reusable, GitHub names the check run
<caller job id> / <reusable job id>, so the context is:copy-artifacts / copy-artifactsgit-clean / copy-artifactsThe trailing
copy-artifactsis the job id insiderainix/.github/workflows/rainix-copy-artifacts.yaml, not anything this repo controls. This PRdoes everything a consumer repo can do; the remaining half is a one-line job-id rename in rainix
itself. That rename would not break any
uses:line —uses:resolves the workflow file, not ajob id — but it would change the context on every consumer at once, including this repo's required
one, so it belongs in its own rainix change rather than here.
The fully-conformant repos (rain.solver, rain.uniswap) show a bare
git-cleanbecause theyhand-roll their steps instead of calling the reusable.
Branch protection — action needed by an owner at merge time
This repo is the one that does require the old context. The
mainruleset(id
21201675) listscopy-artifacts / copy-artifactsunderrequired_status_checks. This PRchanges the context this repo produces to
git-clean / copy-artifacts, so on merge the requiredcontext stops matching anything that runs and the check becomes silently no longer required
until the rule is updated.
Not changed here — a branch protection rule is not this PR's to edit. An owner should update the
ruleset entry from
copy-artifacts / copy-artifactstogit-clean / copy-artifacts. The otherseven required contexts (
rainix-sol / *,rs-static,rs-test,rs-wasm) are untouched.Note the ordering hazard: while this PR is open it produces
git-clean / copy-artifactsand notcopy-artifacts / copy-artifacts, so this PR itself cannot satisfy its own required context —merging it needs either the ruleset updated first or an admin merge.
QA
asserts a workflow's own name. The discriminating evidence is this PR's own check list: the job
must appear with a
git-cleancaller segment and must not appear ascopy-artifacts / copy-artifacts. Verified on the pushed head: it readsgit-clean / copy-artifacts.probe (breaking the
uses:line) is instead guarded by leaving that line byte-identical;grepover the diff confirms
rainix-copy-artifacts.yaml@mainis untouched.git-clean.yaml,name: Git is clean, job idgit-clean), independently confirmed against the two already-conformant repos,rainlanguage/rain.solver and rainlanguage/rain.uniswap. The required-context finding is read
from the live ruleset via the API, not from the issue, which had assumed no protection here.
branch-protection check before renaming; all four covered, and the protection check turned up a
real required context, reported above rather than edited.