Metrics re-write #78
Draft
Metrics re-write #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto prometheusd
…nto prometheusd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #62 with the feature prometheusd. Refer to previous comments in #69
#69 was closed because I wanted to avoid clutter but now I see that I should keep this open for conversation. My bad.
Currently WIP , will hopefully have dogstatsd as well
Detailed
RpcMetrics contains Prometheus gauges and histograms
Threading approach to metrics with MetricSender and MetricRx
Sink and Listener pattern for spinning up in admin startup process
Moved to a seperate mod in admin