Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update questions to use SL Micro 6.0 channels #842

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Sep 10, 2024

Fixes #837

@davidcassany davidcassany requested a review from a team as a code owner September 10, 2024 10:33
@davidcassany davidcassany changed the title Update questions to use SL Micro 6.0 channels (fixes #837) Update questions to use SL Micro 6.0 channels Sep 10, 2024
@@ -1,24 +1,24 @@
questions:
- variable: defaultChannels.sleMicro55.included
show_if: "defaultChannels.sleMicro55"
- variable: defaultChannels.slMicro60Baremetal.included
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slMicro60Baremetal is matching the values.yaml keys. The same applies for the other channels.

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany merged commit cdb34aa into rancher:main Sep 13, 2024
18 of 22 checks passed
@davidcassany davidcassany deleted the fix_questions_for_main branch September 13, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

wrong values in questions.yaml
2 participants