Update helper scripts to 1.6.x channel setup #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
commented
Sep 20, 2024
| echo "${REGISTRY}/rancher/elemental-rt-channel:${OPERATOR}" | ||
| # Note sort -V is a natural numbering sort, not semver | ||
| higher_ver=$(printf '%s\n' "${OPERATOR}" "1.6.0" | sort -rV | head -n1) | ||
| if [ "${higher_ver}" == "1.6.0" ]; then |
There was a problem hiding this comment.
This will not really scale in the future specially when we start providing many different channels per distro stream. So this is just a little patch to keep this script consistent.
anmazzotti
approved these changes
Sep 23, 2024
Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
update_obs_helper_scripts
branch
from
a225aa7
to
6909309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure about the relevance of this script with the new channels scheme. At a time I coded these scripts to list elemental-operator images and to validate channels, but this is loosing it's meaning, now the contents of OS channels are validated by design (we create the contents of it by querying the actual registry) and the channel image itself is decoupled from the operator.
In any case this is just a trivial patch to keep it up to date and consistent.