Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to nmconnections configurator #866

Closed
wants to merge 3 commits into from
Closed

Default to nmconnections configurator #866

wants to merge 3 commits into from

Conversation

anmazzotti
Copy link
Contributor

Due to the absence of nmc in the OS images, the default should be changed to nmconnections then, which will work out of the box.

@anmazzotti
Default to nmconnections configurator
2c9e480 
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
@anmazzotti anmazzotti requested a review from a team as a code owner October 7, 2024 13:37
@anmazzotti
Update manifests
95d0bbe 
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
@anmazzotti
Update chart
c4e7fb7 
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
@anmazzotti anmazzotti mentioned this pull request Oct 7, 2024
Closed
@anmazzotti anmazzotti self-assigned this Oct 7, 2024
davidcassany
davidcassany approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fgiudici
fgiudici requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should change the default.
nmconnections syntax is not really declarative.
I would keep nmc also if we don't have the binary in the OS images yet.

@kkaempf kkaempf added this to the Micro6.1 milestone Oct 8, 2024
@kkaempf kkaempf added the kind/enhancement New feature or request label Oct 8, 2024
@anmazzotti anmazzotti closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgiudici fgiudici fgiudici requested changes

@davidcassany davidcassany davidcassany approved these changes

Assignees

@anmazzotti anmazzotti

Labels
area/networking kind/enhancement New feature or request
Projects
Elemental
Archived in project
Milestone
Micro6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@anmazzotti @davidcassany @fgiudici @kkaempf