Set SELinux in permissive mode on recovery, leave default on active #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
force-pushed
the
set_k3s_selinux_image_in_enforce_mode
branch
3 times, most recently
from
f704c40
to
e39369c
Compare
|
I think this is ready to be merged. I manually tested k3s provisioning from an ISO including these changes and I also checked upgrading from staging to this image works and after reboot the system is on enforcing mode. |
davidcassany
force-pushed
the
set_k3s_selinux_image_in_enforce_mode
branch
from
da96e70
to
987bab0
Compare
frelon
approved these changes
May 8, 2024
There was a problem hiding this comment.
LGTM, but can probably be simplified after rancher/elemental-toolkit#2070 is merged 👍
|
RKE2 provisioning is not fully functional as some files are not getting the appropriate labels. Digging a bit more to figure that out and waiting for rancher/elemental-toolkit#2070 to be merged as this will simplify this PR. |
davidcassany
force-pushed
the
set_k3s_selinux_image_in_enforce_mode
branch
from
0772d01
to
f1ca0f6
Compare
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
set_k3s_selinux_image_in_enforce_mode
branch
from
f1ca0f6
to
5d01dd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1361
Part of #1362