Use suc-upgrade to invoke elemental-register upgrade #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmazzotti
force-pushed
the
use_elemental-register_upgrade
branch
from
a228e15
to
29491a7
Compare
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
anmazzotti
force-pushed
the
use_elemental-register_upgrade
branch
from
bdf0949
to
6cf7134
Compare
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #875 and #1565
The entire logic is going to be replaced by
elemental-register upgrade. See: rancher/elemental-operator#868The
suc-upgradewrapper is still needed for backward compatibility, in case older versions of theelemental-operatorare tasked to upgrade newer OS images.If this is the case, we expect no
ELEMENTAL_REGISTER_UPGRADE_CORRELATION_IDto be set, and the legacyUPGRADE_RECOVERYandUPGRADE_RECOVERY_ONLYvariables need to be supported.FORCEis no longer supported.All the other variables were never documented and some of them are hardcoded, so I took the initiative to remove them.
They can easily be added, as the
elemental-register upgradestill supports them, likeHOST_DIRorCONF_FILEfor example.