Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NeuVector images to auto mirror #609

Closed
wants to merge 0 commits into from

Conversation

selvamt94
Copy link
Contributor

Pull Request Checklist

  • Change does not remove any existing Images or Tags in the images-list file
  • Change does not remove / overwrite exiting Images or Tags in Rancher DockerHub
  • If updating an existing entry, verify the SOURCE is still accurate and upstream hasn't been migrated to a new regitry or repo (if they've migrated, a new repo request to EIO is needed to comply with the SOURCE DESTINATION TAG pattern)
  • New entries are in format SOURCE DESTINATION TAG
  • New entries are added to the correct section of the list (sorted lexicographically)
  • New entries have a repo created in Rancher Dockerhub (where the image will be mirrored to)
  • New entries are licensed with Rancher favored licenses - Apache 2 and MIT - or approved licenses - as according to CNCF approved licenses.
  • New entries, when used in Rancher or Rancher's provided charts, have their corresponding origin added in Rancher's images origins file (must be added for all Rancher versions >= v2.7).
  • Changes to scripting or CI config have been tested to the best of your ability

Types of Change

Linked Issues

Additional Notes

Final Checks after the PR is merged

  • Confirm that you can pull the new images and tags from DockerHub

@selvamt94 selvamt94 requested a review from a team as a code owner April 10, 2024 20:08
@selvamt94
Copy link
Contributor Author

@brandond Can you please merge this PR, I forgot to follow up.

@brandond
Copy link
Member

brandond commented Jun 11, 2024

Don't merge master into your PR branch; this makes for a very weird commit history on your PR branch.

You should rebase your PR onto master, and then force-push to the PR branch on your fork.

Your commits should always be the most recent ones on the PR branch, without other stuff from master on top of them.

@selvamt94
Copy link
Contributor Author

Don't merge master into your PR branch; this makes for a very weird commit history on your PR branch.

You should rebase your PR onto master, and then force-push to the PR branch on your fork.

Your commits should always be the most recent ones on the PR branch, without other stuff from master on top of them.

Sorry for the confusion. I wanted to make another PR to mirror new release, so did like this. I will close this PR and create new for auto mirror. Thanks!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants