fix: wrong result of data rancher2_principal #1335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1330
Problem
When using the data source rancher2_principal to search for a principal, it may return wrong result when one principal name is the prefix of another principal, for example: k8s-admin, k8s-admin-test
Solution
In this code , check the return result is really match the request name.
Testing
As the issue describe.Engineering Testing
Manual Testing
Now the data source rancher2_principal will always return k8s-admin when you set the name as k8s-admin, instead of return k8s-admin-test.
Automated Testing
QA Testing Considerations
Regressions Considerations