-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop the "day of week" boolean column #215
base: branch-0.12
Are you sure you want to change the base?
Conversation
drop the "day of week" boolean column to skip temporarily the error "XGBoostError: Boolean is not supported"
@ayushdg please add in the final code additions and we'll push it to branch-0.11 |
Additions to NYCTaxi-E2E notebook addressing issues on rapidsai-community#214
@taureandyernv / @ayushdg, I have added the final code additions to the patch-2 |
Awesome! I'm testing the updates, and will keep you updated! |
@ayushdg any word? |
Hey. Sorry for the delay. I tried running this on my machine (4XT4's) and I was going OOM. Do we know if this is supposed to work on the full data scale in the notebook? @taureandyernv Regarding the RMM updates, the api is expected to change again. rapidsai/rmm#171. It might be worth waiting for that to land before adding the RMM changes to this notebook. Other than that the notebook looks good to me. |
Looks like rapidsai/rmm#171 just merged 😄 . I'll try to test out the notebook with older version to cudf to ensure that the memory overhead is a result of working with too much data and not a performance regression. Sorry for the delay @vilmara, I'll update this thread when I have the results. |
hi @ayusHD, thanks for the update, I look forward to getting your results |
drop the "day of week" boolean column to skip temporarily the error "XGBoostError: Boolean is not supported"