Skip to content

Commit

Permalink
Remove delete-temp-images job
Browse files Browse the repository at this point in the history
  • Loading branch information
bdice committed Aug 27, 2024
1 parent 08a0e84 commit accbfb3
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 44 deletions.
16 changes: 0 additions & 16 deletions .github/workflows/build-and-publish-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,3 @@ jobs:
BUILD_TYPE: ${{ inputs.build_type }}
IMAGE_NAME: ${{ matrix.IMAGE_NAME }}
run: ci/create-multiarch-manifest.sh
delete-temp-images:
needs: [compute-matrix, build-multiarch-manifest]
runs-on: ubuntu-latest
strategy:
matrix: ${{ fromJSON(needs.compute-matrix.outputs.MATRIX) }}
fail-fast: false
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Remove temporary images
run: ci/remove-temp-images.sh
env:
GPUCIBOT_DOCKERHUB_USER: ${{ secrets.GPUCIBOT_DOCKERHUB_USER }}
GPUCIBOT_DOCKERHUB_TOKEN: ${{ secrets.GPUCIBOT_DOCKERHUB_TOKEN }}
IMAGE_NAME: ${{ matrix.IMAGE_NAME }}
ARCHES: ${{ toJSON(matrix.ARCHES) }}
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,14 @@ docker build $(ci/compute-build-args.sh) -f ci-conda.Dockerfile context/
docker build $(ci/compute-build-args.sh) -f ci-wheel.Dockerfile context/
docker build $(ci/compute-build-args.sh) -f citestwheel.Dockerfile context/
```

## Cleaning Up

Every build first writes images to the https://hub.docker.com/r/rapidsai/staging repo on DockerHub,
then pushes them on to the individual repos like `rapidsai/base`, `rapidsai/notebooks`, etc.

A scheduled job regularly deletes old images from that `rapidsai/staging` repo.
See https://github.com/rapidsai/workflows/blob/main/.github/workflows/cleanup_staging.yaml for details.

If you come back to a pull requests here after more than a few days and find that jobs are failing with errors
that suggest that some necessary images don't exist, re-run all of CI on that pull request to produce new images.
28 changes: 0 additions & 28 deletions ci/remove-temp-images.sh

This file was deleted.

0 comments on commit accbfb3

Please sign in to comment.