Skip to content

Commit

Permalink
Match casing in FROM & AS to fix GHA warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
jakirkham committed Aug 15, 2024
1 parent 358b5d1 commit aed4336
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions ci-conda.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ ARG PYTHON_VER=notset
ARG YQ_VER
ARG AWS_CLI_VER

FROM mikefarah/yq:${YQ_VER} as yq
FROM mikefarah/yq:${YQ_VER} AS yq

Check warning on line 7 in ci-conda.Dockerfile

View workflow job for this annotation

GitHub Actions / build-images / docker (11.4.3, 3.9, rockylinux8, ci-conda, amd64, arm64, rapidsai/staging:ci-conda-170-cuda11.4.... / build (11.4.3, 3.9, rockylinux8, amd64)

Default value for global ARG results in an empty or invalid base image name

InvalidDefaultArgInFrom: Default value for ARG mikefarah/yq:${YQ_VER} results in empty or invalid base image name More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

FROM amazon/aws-cli:${AWS_CLI_VER} as aws-cli
FROM amazon/aws-cli:${AWS_CLI_VER} AS aws-cli

Check warning on line 9 in ci-conda.Dockerfile

View workflow job for this annotation

GitHub Actions / build-images / docker (11.4.3, 3.9, rockylinux8, ci-conda, amd64, arm64, rapidsai/staging:ci-conda-170-cuda11.4.... / build (11.4.3, 3.9, rockylinux8, amd64)

Default value for global ARG results in an empty or invalid base image name

InvalidDefaultArgInFrom: Default value for ARG amazon/aws-cli:${AWS_CLI_VER} results in empty or invalid base image name More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

FROM rapidsai/miniforge-cuda:cuda${CUDA_VER}-base-${LINUX_VER}-py${PYTHON_VER}

Expand Down
2 changes: 1 addition & 1 deletion ci-wheel.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ARG LINUX_VER=notset
ARG BASE_IMAGE=nvcr.io/nvidia/cuda:${CUDA_VER}-devel-${LINUX_VER}
ARG AWS_CLI_VER

FROM amazon/aws-cli:${AWS_CLI_VER} as aws-cli
FROM amazon/aws-cli:${AWS_CLI_VER} AS aws-cli

FROM ${BASE_IMAGE}

Expand Down
2 changes: 1 addition & 1 deletion citestwheel.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ARG LINUX_VER=notset
ARG BASE_IMAGE=nvcr.io/nvidia/cuda:${CUDA_VER}-devel-${LINUX_VER}
ARG AWS_CLI_VER

FROM amazon/aws-cli:${AWS_CLI_VER} as aws-cli
FROM amazon/aws-cli:${AWS_CLI_VER} AS aws-cli

FROM ${BASE_IMAGE}

Expand Down

0 comments on commit aed4336

Please sign in to comment.