-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build wheels alongside conda CI #12427
Merged
rapids-bot
merged 30 commits into
rapidsai:branch-23.02
from
sevagh:feat/wheels/py310-ctk12-wheels
Jan 10, 2023
Merged
Changes from 29 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
628de05
Build wheels alongside conda CI
sevagh c51c692
Retrigger build
sevagh 72ea6a4
Retrigger build
sevagh 5cbaac4
Put wheel name at end of job name
sevagh f83d795
Use unified publish workflow
sevagh 5eec7dd
Add wheel parameters to build.yaml inputs
sevagh fba1239
Separate publish workflows
sevagh a993a3f
Use bigger Pyarrow interop smoke test
sevagh 0124cd1
Try escaped double-quotes instead
sevagh 782b2af
Move smoke test to its own file
sevagh bb610d1
Add copyright to smoke test file
sevagh 77d3694
Merge branch 'branch-23.02' into feat/wheels/py310-ctk12-wheels
ajschmidt8 bc578d8
fix copyright headers
ajschmidt8 1794af8
make wheel builds depend on `checks`
ajschmidt8 04e5add
Install pyarrow 10.0.1
sevagh 68f3ee4
Add one more assert to smoke test; drop print statement
sevagh 0aeabe2
Copyright fix in cudf/setup.py
sevagh 4608733
Merge branch 'branch-23.02' into feat/wheels/py310-ctk12-wheels
sevagh 5ea3a5f
Removed some wheel parameters
sevagh 037ef3d
Update arrow versioning logic.
vyasr 35a6c30
More accurate comment.
vyasr c070aa5
Use main version of improved wheel workflows
sevagh f81bc92
Use current-workflow cudf wheel for dask-cudf
sevagh 5157326
Use branch of shared-action-workflows
sevagh 22e3951
Pure wheels use test-before no arch
sevagh c364ec8
Use correct RAPIDS_PY_WHEEL_NAME
sevagh caa95a7
Trigger build
sevagh acf191e
Remove unneeded repo: keys
sevagh e214f83
Merge branch 'branch-23.02' into feat/wheels/py310-ctk12-wheels
ajschmidt8 6492d1a
before-wheel param is now supported by main workflow
sevagh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,10 @@ jobs: | |
- conda-python-other-tests | ||
- conda-java-tests | ||
- conda-notebook-tests | ||
- wheel-build-cudf | ||
- wheel-tests-cudf | ||
- wheel-build-dask-cudf | ||
- wheel-tests-dask-cudf | ||
secrets: inherit | ||
uses: rapidsai/shared-action-workflows/.github/workflows/pr-builder.yaml@main | ||
checks: | ||
|
@@ -78,3 +82,40 @@ jobs: | |
arch: "amd64" | ||
container_image: "rapidsai/ci:latest" | ||
run_script: "ci/test_notebooks.sh" | ||
wheel-build-cudf: | ||
needs: checks | ||
secrets: inherit | ||
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-manylinux-build.yml@main | ||
with: | ||
build_type: pull-request | ||
package-name: cudf | ||
package-dir: python/cudf | ||
skbuild-configure-options: "-DCUDF_BUILD_WHEELS=ON -DDETECT_CONDA_ENV=OFF" | ||
wheel-tests-cudf: | ||
needs: wheel-build-cudf | ||
secrets: inherit | ||
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-manylinux-test.yml@main | ||
with: | ||
build_type: pull-request | ||
package-name: cudf | ||
test-before-arm64: "pip install tokenizers==0.10.2 cupy-cuda11x -f https://pip.cupy.dev/aarch64" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since it's already working we can leave it for now, but I'll note that in #12377 we actually removed tokenizers from arm tests and only test on x86 for conda packages. |
||
test-unittest: "pytest -v -n 8 ./python/cudf/cudf/tests" | ||
test-smoketest: "python ./ci/wheel_smoke_test_cudf.py" | ||
wheel-build-dask-cudf: | ||
needs: wheel-build-cudf | ||
secrets: inherit | ||
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-pure-build.yml@feat/wheels-local-dependency | ||
with: | ||
build_type: pull-request | ||
package-name: dask_cudf | ||
package-dir: python/dask_cudf | ||
before-wheel: "RAPIDS_PY_WHEEL_NAME=cudf_cu11 rapids-download-wheels-from-s3 ./local-cudf && pip install --no-deps ./local-cudf/cudf*.whl" | ||
wheel-tests-dask-cudf: | ||
needs: wheel-build-dask-cudf | ||
secrets: inherit | ||
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-pure-test.yml@main | ||
with: | ||
build_type: pull-request | ||
package-name: dask_cudf | ||
test-before: "RAPIDS_PY_WHEEL_NAME=cudf_cu11 rapids-download-wheels-from-s3 ./local-cudf-dep && pip install --no-deps ./local-cudf-dep/cudf*.whl" | ||
test-unittest: "pytest -v -n 8 ./python/dask_cudf/dask_cudf/tests" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Copyright (c) 2022-2023, NVIDIA CORPORATION. | ||
|
||
import cudf | ||
import pyarrow as pa | ||
|
||
if __name__ == '__main__': | ||
n_legs = pa.array([2, 4, 5, 100]) | ||
animals = pa.array(["Flamingo", "Horse", "Brittle stars", "Centipede"]) | ||
names = ["n_legs", "animals"] | ||
foo = pa.table([n_legs, animals], names=names) | ||
df = cudf.DataFrame.from_arrow(foo) | ||
assert df.loc[df["animals"] == "Centipede"]["n_legs"].iloc[0] == 100 | ||
assert df.loc[df["animals"] == "Flamingo"]["n_legs"].iloc[0] == 2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave this for now (something I will raise more broadly in the new year) but AFAIK this variable doesn't do anything right now. The question would be whether it should be set to do anything. That's a rapids-wide discussion though; I think only cuML is actively making use of this now and that's partly because it needs to forward along to deps like treelite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rapidsai/rapids-cmake#334