Skip to content

Commit

Permalink
add setuptools to host requirements for conda packages that need it (#…
Browse files Browse the repository at this point in the history
…4582)

@caryr35 pointed out to me this morning that `cugraph`'s nightly CI is failing. All `conda-python-build` jobs are failing like this, when building `nx-cugraph`

> ModuleNotFoundError: No module named 'setuptools'
> ...
> ValueError: Could not import build backend specified in pyproject.toml's tool.rapids-build-backend table. Make sure you specified the right optional dependency in your build-system.requires entry for rapids-build-backend.

([build link](https://github.com/rapidsai/cugraph/actions/runs/10176436224/job/28166520972))

**suspected root cause:**  `nx-cugraph` uses `setuptools.build_meta`, but `setuptools` isn't present in the conda build environment

## Notes for Reviewers

### Why is this targeting `branch-24.08`?

Looks like CI is failing there too: https://github.com/rapidsai/cugraph/actions/runs/10183681336/job/28171285190

### Why is this just breaking now?

I suspect that prior to this we were getting `setuptools` because it was a transitive dependency of one of `nx-cugraph`'s other build/host dependencies.

### How could we prevent stuff like this in the future?

We could add support for updating conda recipe files in `rapids-dependency-file-generator` (rapidsai/dependency-file-generator#7).

`setuptools` was correctly added as a build dependency in `pyproject.toml` files here (automatically, via `dependencies.yaml` + `rapids-dependency-file-generator`), but the conda recipe `meta.yaml` files were missed.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Bradley Dice (https://github.com/bdice)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #4582
  • Loading branch information
jameslamb authored Jul 31, 2024
1 parent b38e010 commit 969ea3e
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions conda/recipes/cugraph-dgl/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ requirements:
host:
- python
- rapids-build-backend>=0.3.1,<0.4.0.dev0
- setuptools>=61.0.0
run:
- cugraph ={{ version }}
- dgl >=1.1.0.cu*
Expand Down
1 change: 1 addition & 0 deletions conda/recipes/cugraph-equivariant/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ requirements:
host:
- python
- rapids-build-backend>=0.3.1,<0.4.0.dev0
- setuptools>=61.0.0
run:
- pylibcugraphops ={{ minor_version }}
- python
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/cugraph-pyg/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ requirements:
host:
- cython >=3.0.0
- python
- scikit-build-core >=0.7.0
- rapids-build-backend>=0.3.1,<0.4.0.dev0
- setuptools>=61.0.0
run:
- rapids-dask-dependency ={{ minor_version }}
- numba >=0.57
Expand Down
3 changes: 2 additions & 1 deletion conda/recipes/cugraph-service/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ outputs:
- pip
- python
- rapids-build-backend>=0.3.1,<0.4.0.dev0
- setuptools>=61.0.0
run:
- python
- thriftpy2 >=0.4.15,!=0.5.0,!=0.5.1
Expand All @@ -51,7 +52,7 @@ outputs:
host:
- pip
- python
- setuptools
- setuptools>=61.0.0
- wheel
- rapids-build-backend>=0.3.1,<0.4.0.dev0
run:
Expand Down
1 change: 1 addition & 0 deletions conda/recipes/nx-cugraph/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ requirements:
host:
- python
- rapids-build-backend>=0.3.1,<0.4.0.dev0
- setuptools>=61.0.0
run:
- pylibcugraph ={{ version }}
- networkx >=3.0
Expand Down

0 comments on commit 969ea3e

Please sign in to comment.