Skip to content

Commit

Permalink
Merge branch 'branch-24.08' of github.com:rapidsai/cugraph into feat/…
Browse files Browse the repository at this point in the history
…cpp_wheel
  • Loading branch information
msarahan committed Jun 28, 2024
2 parents 0da5611 + ece789d commit bd6015f
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 7 deletions.
3 changes: 2 additions & 1 deletion conda/environments/all_cuda-118_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ dependencies:
- numpy>=1.23,<2.0a0
- numpydoc
- nvcc_linux-64=11.8
- openmpi<5.0.3
- openmpi
- packaging>=21
- pandas
- pre-commit
Expand Down Expand Up @@ -70,6 +70,7 @@ dependencies:
- sphinx-markdown-tables
- sphinx<6
- sphinxcontrib-websupport
- thriftpy2<=0.5.0
- ucx-proc=*=gpu
- ucx-py==0.39.*
- wget
Expand Down
3 changes: 2 additions & 1 deletion conda/environments/all_cuda-122_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ dependencies:
- numba>=0.57
- numpy>=1.23,<2.0a0
- numpydoc
- openmpi<5.0.3
- openmpi
- packaging>=21
- pandas
- pre-commit
Expand Down Expand Up @@ -75,6 +75,7 @@ dependencies:
- sphinx-markdown-tables
- sphinx<6
- sphinxcontrib-websupport
- thriftpy2<=0.5.0
- ucx-proc=*=gpu
- ucx-py==0.39.*
- wget
Expand Down
14 changes: 10 additions & 4 deletions cpp/tests/utilities/base_fixture.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,18 @@ inline auto make_cuda() { return std::make_shared<rmm::mr::cuda_memory_resource>

inline auto make_managed() { return std::make_shared<rmm::mr::managed_memory_resource>(); }

inline auto make_pool()
// use_max set to true will use half of available GPU memory for RMM, otherwise
// otherwise we'll use 1/10.
inline auto make_pool(bool use_max = false)
{
// Reduce the default pool allocation to 1/6th of the GPU memory so that we can
// Reduce the default pool allocation to 1/10 of GPU memory so that we can
// run more than 2 tests in parallel at the same time. Changes to this value could
// effect the maximum amount of parallel tests, and therefore `tests/CMakeLists.txt`
// `_CUGRAPH_TEST_PERCENT` default value will need to be audited.
auto const [free, total] = rmm::available_device_memory();
auto const min_alloc = rmm::align_down(std::min(free, total / 6), rmm::CUDA_ALLOCATION_ALIGNMENT);
auto const min_alloc =
use_max ? rmm::align_down(std::min(free, total / 2), rmm::CUDA_ALLOCATION_ALIGNMENT)
: rmm::align_down(std::min(free, total / 10), rmm::CUDA_ALLOCATION_ALIGNMENT);
return rmm::mr::make_owning_wrapper<rmm::mr::pool_memory_resource>(make_cuda(), min_alloc);
}

Expand All @@ -99,7 +103,8 @@ inline auto make_binning()
* @throw cugraph::logic_error if the `allocation_mode` is unsupported.
*
* @param allocation_mode String identifies which resource type.
* Accepted types are "pool", "cuda", and "managed" only.
* Accepted types are "pool", "cuda", "managed" and
* "maxpool" only.
* @return Memory resource instance
*/
inline std::shared_ptr<rmm::mr::device_memory_resource> create_memory_resource(
Expand All @@ -108,6 +113,7 @@ inline std::shared_ptr<rmm::mr::device_memory_resource> create_memory_resource(
if (allocation_mode == "binning") return make_binning();
if (allocation_mode == "cuda") return make_cuda();
if (allocation_mode == "pool") return make_pool();
if (allocation_mode == "maxpool") return make_pool(true);
if (allocation_mode == "managed") return make_managed();
CUGRAPH_FAIL("Invalid RMM allocation mode");
}
Expand Down
5 changes: 4 additions & 1 deletion dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ dependencies:
- libraft-headers==24.8.*
- libraft==24.8.*
- librmm==24.8.*
- openmpi<5.0.3 # Required for building cpp-mgtests (multi-GPU tests)
- openmpi # Required for building cpp-mgtests (multi-GPU tests)
specific:
- output_types: [conda]
matrices:
Expand Down Expand Up @@ -583,6 +583,9 @@ dependencies:
- output_types: [conda]
packages:
- pylibwholegraph==24.8.*
# this thriftpy2 entry can be removed entirely (or switched to a '!=')
# once a new release of that project resolves https://github.com/Thriftpy/thriftpy2/issues/281
- thriftpy2<=0.5.0
test_python_pylibcugraph:
common:
- output_types: [conda, pyproject]
Expand Down

0 comments on commit bd6015f

Please sign in to comment.