Skip to content

Commit

Permalink
remove telemetry from shared workflows that don't have it
Browse files Browse the repository at this point in the history
  • Loading branch information
msarahan committed Oct 29, 2024
1 parent cbca97d commit c42dcc9
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ concurrency:

env:
# TODO: put this in a shared org-wide secret?
OTEL_SERVICE_NAME: 'pr-cudf'
OTEL_SERVICE_NAME: 'pr-cugraph'
# TODO: this should be set as an org-wide variable
OTEL_EXPORTER_OTLP_ENDPOINT: https://tempo.gha-runners.nvidia.com:4318
# These are where the secrets in github env vars are written to files. These files don't
Expand Down Expand Up @@ -129,7 +129,7 @@ jobs:
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@add-telemetry
with:
enable_check_generated_files: false
ignored_pr_jobs: "final_span_update"
ignored_pr_jobs: "final-telemetry-update"
default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
conda-cpp-build:
Expand Down Expand Up @@ -160,8 +160,6 @@ jobs:
build_type: pull-request
enable_check_symbols: true
symbol_exclusions: (cugraph::ops|hornet|void writeEdgeCountsKernel|void markUniqueOffsetsKernel)
default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
conda-python-build:
needs: [conda-cpp-build, telemetry-setup]
secrets: inherit
Expand Down Expand Up @@ -329,19 +327,16 @@ jobs:
devcontainer:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@add-telemetry
needs: telemetry-setup
with:
arch: '["amd64"]'
cuda: '["12.5"]'
node_type: cpu32
extra-repo-deploy-key: CUGRAPH_OPS_SSH_PRIVATE_DEPLOY_KEY
default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
build_command: |
sccache -z;
build-all --verbose -j$(nproc --ignore=1) -DBUILD_CUGRAPH_MG_TESTS=ON;
sccache -s;
final_span_update:
final-telemetry-update:
runs-on: ubuntu-latest
needs: [pr-builder, telemetry-setup]
steps:
Expand Down

0 comments on commit c42dcc9

Please sign in to comment.