Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old dask-glm based logistic regression #6028

Merged
merged 9 commits into from
Oct 3, 2024
Merged

Remove old dask-glm based logistic regression #6028

merged 9 commits into from
Oct 3, 2024

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Aug 16, 2024

closes #6025

@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Aug 16, 2024
@dantegd dantegd added improvement Improvement / enhancement to an existing function breaking Breaking change labels Aug 16, 2024
@bdice
Copy link
Contributor

bdice commented Sep 16, 2024

I promised a followup on #6060. I have now updated this PR to remove the setuptools dependency that was required by dask-glm on Python 3.12.

@divyegala divyegala marked this pull request as ready for review September 23, 2024 17:16
@divyegala divyegala requested review from a team as code owners September 23, 2024 17:16
bdice
bdice approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approving the packaging changes here, since they were discussed with several team members on a previous PR.

@dantegd
Copy link
Member Author

dantegd commented Oct 3, 2024

/merge

@rapids-bot rapids-bot bot merged commit 8ed7bda into rapidsai:branch-24.10 Oct 3, 2024
62 checks passed
@divyegala divyegala mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@bdice bdice bdice approved these changes

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
breaking Breaking change conda conda issue Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating Dask-GLM?
3 participants
@dantegd @bdice @divyegala