Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dask-sql to 2023.11.0 #617

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Update dask-sql to 2023.11.0 #617

merged 1 commit into from
Dec 7, 2023

Conversation

raydouglass
Copy link
Member

@raydouglass raydouglass commented Dec 7, 2023 •
edited
Loading

Closes #607
Closes #614

RAPIDS 23.12 uses dask 2023.11.0 (rapidsai/rapids-dask-dependency#6), so need to update dask-sql to match (conda-forge/dask-sql-feedstock#78).

This should resolve the conflicts seen here: https://github.com/rapidsai/docker/actions/runs/7130639487/job/19419248901#step:9:235

@raydouglass raydouglass requested a review from a team as a code owner December 7, 2023 18:58
@bdice
Copy link
Contributor

bdice commented Dec 7, 2023

Do we normally ignore or merge the PRs like #607 / #614?

@raydouglass
Copy link
Member Author

Do we normally ignore or merge the PRs like #607 / #614?

That's the preferred way to update dask-sql, but it's not routinely checked.

#607 should have been tested & merged back when it opened. But due #579, it cannot be merged now.

@raydouglass
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 33b72a5 into rapidsai:branch-23.12 Dec 7, 2023
12 of 17 checks passed
@raydouglass raydouglass deleted the dask-sql-2023.11.0 branch December 7, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raydouglass @bdice @ajschmidt8