fix virtual dtor

rapidsai · Oct 1, 2024 · 8726f87 · 8726f87
1 parent 628e525
commit 8726f87
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/cpp/include/kvikio/remote_handle.hpp b/cpp/include/kvikio/remote_handle.hpp
@@ -333,6 +333,8 @@ class RemoteEndpoint {
    * @returns A string description.
    */
   virtual std::string str() = 0;
+
+  virtual ~RemoteEndpoint() = default;
 };
 
 /**
@@ -343,7 +345,6 @@ class HttpEndpoint : public RemoteEndpoint {
   std::string _url;
 
  public:
-  HttpEndpoint() = default;
   HttpEndpoint(std::string url) : _url{std::move(url)} {}
   void setopt(detail::CurlHandle& curl) override { curl.setopt(CURLOPT_URL, _url.c_str()); }
   std::string str() override { return _url; }

diff --git a/python/kvikio/kvikio/benchmarks/http_io.py b/python/kvikio/kvikio/benchmarks/http_io.py
@@ -38,8 +38,8 @@ def run() -> float:
 
 
 API = {
-    "cupy-kvikio": partial(run_numpy_like, xp=cupy),
-    "numpy-kvikio": partial(run_numpy_like, xp=numpy),
+    "cupy": partial(run_numpy_like, xp=cupy),
+    "numpy": partial(run_numpy_like, xp=numpy),
 }