Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
  • Loading branch information
3 people authored Oct 3, 2024
1 parent b8a9c0a commit 9cffe1c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ rapids_cmake_write_version_file(include/kvikio/version_config.hpp)
rapids_cmake_build_type(Release)

# build options
option(KvikIO_REMOTE_SUPPORT "Configure CMake to build with remote io support" ON)
option(KvikIO_REMOTE_SUPPORT "Configure CMake to build with remote IO support" ON)
option(KvikIO_BUILD_EXAMPLES "Configure CMake to build examples" ON)
option(KvikIO_BUILD_TESTS "Configure CMake to build tests" ON)

Expand Down
8 changes: 4 additions & 4 deletions cpp/include/kvikio/remote_handle.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ inline std::size_t callback_host_memory(char* data,
void* context)
{
auto ctx = reinterpret_cast<CallbackContext*>(context);
const std::size_t nbytes = size * nmemb;
std::size_t const nbytes = size * nmemb;
if (ctx->size < ctx->offset + nbytes) {
ctx->overflow_error = true;
return CURL_WRITEFUNC_ERROR;
Expand Down Expand Up @@ -107,10 +107,10 @@ inline std::size_t callback_device_memory(char* data,
/**
* @brief Abstract base class for remote endpoints.
*
* In this context, an endpoint refers to a remote file using a specify communication protocol.
* In this context, an endpoint refers to a remote file using a specific communication protocol.
*
* Each communication protocol, such as HTTP or S3, needs to implement this ABC and implement
* their own ctor that takes communication protocol specific arguments.
* its own ctor that takes communication protocol specific arguments.
*/
class RemoteEndpoint {
public:
Expand Down Expand Up @@ -159,7 +159,7 @@ class RemoteHandle {
/**
* @brief Create a new remote handle from an endpoint and a file size.
*
* @param endpoint Remote endpoint used for subsequently IO.
* @param endpoint Remote endpoint used for subsequent IO.
* @param nbytes The size of the remote file (in bytes).
*/
RemoteHandle(std::unique_ptr<RemoteEndpoint> endpoint, std::size_t nbytes)
Expand Down
6 changes: 3 additions & 3 deletions cpp/include/kvikio/shim/libcurl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ namespace kvikio {
*/
class LibCurl {
public:
// We hold an unique pointer to the raw curl handle and sets `curl_easy_cleanup` as its Deleter.
// We hold a unique pointer to the raw curl handle and set `curl_easy_cleanup` as its Deleter.
using UniqueHandlePtr = std::unique_ptr<CURL, std::function<void(CURL*)>>;

private:
Expand Down Expand Up @@ -137,7 +137,7 @@ class LibCurl {
* @brief Representation of a curl easy handle pointer and its operations.
*
* An instance is given a `LibCurl::UniqueHandlePtr` on creation, which is
* later retailed on destruction.
* later retained on destruction.
*/
class CurlHandle {
private:
Expand All @@ -152,7 +152,7 @@ class CurlHandle {
*
* Typically, do not use this directly instead use the `create_curl_handle()` macro.
*
* @param handle An unused curl easy handle pointer, which is retailed on destruction.
* @param handle An unused curl easy handle pointer, which is retained on destruction.
* @param source_file Path of source file of the caller (for error messages).
* @param source_line Line of source file of the caller (for error messages).
*/
Expand Down

0 comments on commit 9cffe1c

Please sign in to comment.