Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow nvcomp git checkout #704

Open
wants to merge 1 commit into
base: branch-24.12
Choose a base branch
from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 16, 2024

Description

Closes #702.

This adopts a minimal approach that does not affect parsing logic, it only disables git checkout of the nvcomp dependency.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice requested a review from a team as a code owner October 16, 2024 13:48
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 16, 2024
@bdice
Copy link
Contributor Author

bdice commented Oct 16, 2024

I am marking this as non-breaking because the nvcomp 2.2.0 git checkout has been unsupported for a while.

Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the tests in CI to account for the fact that Git is no longer supported.

You may even consider throwing an error if PROPRIETARY_BINARY is not passed.

@bdice
Copy link
Contributor Author

bdice commented Oct 16, 2024

@KyleFromNVIDIA If you have bandwidth, I would appreciate help with this. Otherwise I will come back to it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Relax requirements for versions.json git_url / git_tag for proprietary binaries
2 participants