Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build wheels alongside conda CI #1182

Merged
merged 19 commits into from
Jan 6, 2023
Merged

Build wheels alongside conda CI #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9b2b116
Build wheels alongside conda CI
sevagh Dec 20, 2022
61a8f2a
Use build_type for wheels
sevagh Dec 20, 2022
7ec0cd8
Remove package-dir param from wheel test/publish
sevagh Dec 20, 2022
8780679
Use unified publish workflow
sevagh Dec 21, 2022
3cf1ba1
Rename python-package-build-tag
sevagh Dec 21, 2022
a6032c2
wheel-publish needs wheel-build
sevagh Dec 21, 2022
137d9b0
Adjust versioneer-override param name
sevagh Dec 21, 2022
e0a6859
Add smoketest for abbreviated arm PR CI
sevagh Dec 21, 2022
d0d7284
Back to separate manylinux publish workflow
sevagh Dec 21, 2022
1e48bbf
Move smoke test to its own file
sevagh Dec 21, 2022
963c295
Fix style of smoke test file
sevagh Dec 21, 2022
0285ee8
Merge branch 'branch-23.02' into feat/wheels/py310-ctk12-wheels
ajschmidt8 Jan 5, 2023
8ba463f
make wheel builds depend on `checks`
ajschmidt8 Jan 5, 2023
ff6b4e3
Merge branch 'branch-23.02' into feat/wheels/py310-ctk12-wheels
ajschmidt8 Jan 6, 2023
5858256
Address PR feedback
sevagh Jan 6, 2023
b039914
Removed some wheel parameters
sevagh Jan 6, 2023
a1f1cb7
Rebuild
sevagh Jan 6, 2023
bcd0221
Rebuild
sevagh Jan 6, 2023
d76979d
Use main branch for improved wheel workflows
sevagh Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,26 @@ jobs:
branch: ${{ inputs.branch }}
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
wheel-build:
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-manylinux-build.yml@main
with:
build_type: ${{ inputs.build_type || 'branch' }}
repo: rapidsai/rmm
branch: ${{ inputs.branch }}
sha: ${{ inputs.sha }}
date: ${{ inputs.date }}
package-name: rmm
package-dir: python
skbuild-configure-options: "-DRMM_BUILD_WHEELS=ON"
wheel-publish:
needs: wheel-build
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-manylinux-publish.yml@main
with:
build_type: ${{ inputs.build_type || 'branch' }}
repo: rapidsai/rmm
branch: ${{ inputs.branch }}
sha: ${{ inputs.sha }}
date: ${{ inputs.date }}
package-name: rmm
20 changes: 20 additions & 0 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ jobs:
- conda-cpp-tests
- conda-python-build
- conda-python-tests
- wheel-build
- wheel-tests
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/pr-builder.yaml@cuda-118
checks:
Expand Down Expand Up @@ -46,3 +48,21 @@ jobs:
uses: rapidsai/shared-action-workflows/.github/workflows/conda-python-tests.yaml@cuda-118
with:
build_type: pull-request
wheel-build:
needs: checks
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-manylinux-build.yml@main
with:
build_type: pull-request
package-dir: python
package-name: rmm
skbuild-configure-options: "-DRMM_BUILD_WHEELS=ON"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It annoys me that we have to specify this in every repo, but I don't see a great WAR at this stage. For now, just making a note that this is one more bit of boilerplate that it would be nice to get rid of somehow.

wheel-tests:
needs: wheel-build
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-manylinux-test.yml@main
with:
build_type: pull-request
package-name: rmm
test-unittest: "python -m pytest -v ./python/rmm/tests"
test-smoketest: "python ./ci/wheel_smoke_test.py"
11 changes: 11 additions & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,14 @@ jobs:
branch: ${{ inputs.branch }}
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
wheel-tests:
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-manylinux-test.yml@main
with:
build_type: nightly
repo: rapidsai/rmm
branch: ${{ inputs.branch }}
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
package-name: rmm
test-unittest: "python -m pytest -v ./python/rmm/tests"
52 changes: 0 additions & 52 deletions .github/workflows/wheels.yml
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions ci/wheel_smoke_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import rmm

if __name__ == "__main__":
buf = rmm.DeviceBuffer(size=100)
assert buf.size == 100