RavenDB-27141 Reject two licence sources and fix from_external_server - #40
Open
poissoncorp wants to merge 1 commit into
Open
RavenDB-27141 Reject two licence sources and fix from_external_server#40poissoncorp wants to merge 1 commit into
poissoncorp wants to merge 1 commit into
Conversation
…er through with_external_server The runner emitted both --License and --License.Path when both were set, letting the server pick one and hiding the mistake; C# raises instead (RavenServerRunner.cs:37-39). from_external_server also predated with_external_server, so it never learned to run a server directory in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two defects found while syncing the test driver with C# (RavenDB-27141).
55 tests, all passing.
Fixes
Two licence sources were both passed to the server
ServerOptions.licensinghaslicense(inline JSON) andlicense_path. They are alternatives. The runner emitted both when both were set, so the server picked one and the mistake stayed invisible. C# raises instead (RavenServerRunner.cs:37-39).The existing test set both and asserted both arguments reached the server, so it pinned the defect in place. It is now two tests, one licence source each, plus one for the rejection.
from_external_serverdid not run a server directory in placewith_external_serverlearned to run a directory where it stands, instead of copying it to the default target location. The olderfrom_external_serverclassmethod never got that, so the same path behaved differently depending on which entry point you used. It now forwards towith_external_serverand warns.Deprecations
ServerOptions.from_external_server()still works and emitsDeprecationWarning. Use:Not in this PR
The default
data_directorystill points inside the installed package. Commitb8f140d("RavenDB-27140 Preserve configuration defaults") reverted that deliberately, together withaccept_eulaandframework_version, and its body is empty, so the reasoning is not recorded anywhere. That needs its author before anyone flips it a second time.