Feat: Add type support for multiline plain text inputs #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raycharius
reviewed
Dec 19, 2023
src/elements/index.ts
Outdated
| * @param {int} [params.minLength] Sets a minimum character count in order for the user to submit the form. | ||
| * @param {int} [params.maxLength] Sets a maximum character count allowed to send the form. | ||
| * | ||
| * {@link https://api.slack.com/reference/block-kit/block-elements#input|View in Slack API Documentation} | ||
| */ | ||
|
|
||
| export function TextInput(params?: TextInputParams): TextInputBuilder { | ||
| return new TextInputBuilder(params); | ||
| const input = new TextInputBuilder(params); | ||
| return input; |
There was a problem hiding this comment.
Could we return this back to the return new TextInputBuilder(params)? To keep it consistent with the rest of the codebase
After that, happy to approve and merge!
There was a problem hiding this comment.
Sure thing! Done :)
carlovsk
force-pushed
the
feat/multiline-text-input
branch
from
23ab569
to
71cd188
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 91 92 +1
Lines 1360 1383 +23
Branches 119 121 +2
=======================================
+ Hits 1358 1381 +23
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the issue #121.
Just adding type support for the multiline option on Plan Text Inputs.