fix: Update slack-dto.ts #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanguyantoine
force-pushed
the
patch-2
branch
2 times, most recently
from
fba7696
to
7f0595b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 91 91
Lines 1360 1360
Branches 119 119
=======================================
Hits 1358 1358
Misses 2 2 ☔ View full report in Codecov by Sentry. |
fixes this typing error: Argument of type 'Readonly<SlackMessageDto>' is not assignable to parameter of type 'ChatUpdateArguments'.
Property 'ts' is missing in type 'Readonly<SlackMessageDto>' but required in type 'ChatUpdateArguments'.
when doing
```ts
await client.chat.update(
Message()
//omitted for brevity
.channel('channel_id')
.ts('message_ts)
.buildToObject()
)
```
tanguyantoine
force-pushed
the
patch-2
branch
from
7f0595b
to
2edf770
Compare
|
@raycharius For some reason commit check does not work 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes this typing error: Argument of type 'Readonly' is not assignable to parameter of type 'ChatUpdateArguments'.
Property 'ts' is missing in type 'Readonly' but required in type 'ChatUpdateArguments'.
when doing