[RFC] Smbios improvement v3 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add interface for sysinfo to access a data area from the platform. This is useful to save/read a memory region of platform-specific data. Signed-off-by: Raymond Mao <raymond.mao@linaro.org>
Add sysinfo interface and definitions to support SMBIOS type 0 to type 4. Signed-off-by: Raymond Mao <raymond.mao@linaro.org>
Current SMBIOS library does not fully match to the specification. It hardcodes values instead of exposing values from the device. It does not support dynamic length for contained object handles or elements and misses the handling of a few fields. The refactoring of this patch includes: 1. Expose values from device via sysinfo interface. 2. Replace smbios_add_prop with smbios_add_prop_si to allow getting string values from sysinfo. 3. Add smbios_get_val_si to get int values from sysinfo. 4. Use sysinfo_get_data to get data area like contained object handles, elements or processor id. 5. Refactor SMBIOS cmd print functions to match the command output with the specification 6. Add new print functions for Type 0, 3 and 4. 7. Miscellaneous fixes in SMBIOS. Signed-off-by: Raymond Mao <raymond.mao@linaro.org>
Add common sysinfo driver for armv8 platforms containing all necessary SMBIOS information (Type 1 to 4). Signed-off-by: Raymond Mao <raymond.mao@linaro.org>
Add sysinfo interface and data structures for cache information required by SMBIOS type 7. Signed-off-by: Raymond Mao <raymond.mao@linaro.org>
Add SMBIOS type 7 (cache information) write functions. Link cache handles from type 7 to type 4. Add SMBIOS command print functions for type 7. Signed-off-by: Raymond Mao <raymond.mao@linaro.org>
Add cache information sysinfo driver containing necessary information required by SMBIOS type 7 for all armv8 platforms. Signed-off-by: Raymond Mao <raymond.mao@linaro.org>
Enable sysinfo smbios by default for Arm64. Do not enable QFW if SYSINFO_SMBIOS is defined. Signed-off-by: Raymond Mao <raymond.mao@linaro.org>
raymo200915
force-pushed
the
smbios_improvement_3
branch
from
f96a1e6
to
80f5e03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve SMBIOS support with sysinfo platform-specific driver (armv8) and add all required structure types which are currently missing:
Type 7 - Cache Information
Type 9 - System Slots
Type 16 - Physical Memory Array
Type 17 - Memory Device
Type 19 - Memory Array Mapped Address
Test on qemu_arm64:
Disable
CONFIG_CMD_QFW;Enable
CONFIG_GENERATE_SMBIOS_TABLE,CONFIG_SYSINFOandCONFIG_SYSINFO_SMBIOS.Run
smbioscommand in the U-Boot console.This PR is based on #8, with below refactoring:
.platof DRVINFO, and make it extensible for future to support other architectures.