add minMonthlyDownloads filter for Trending, a11y fixes
#1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
approved these changes
Oct 18, 2024
brentvatne
reviewed
Oct 18, 2024
pages/trending.tsx
Outdated
| @@ -93,7 +93,7 @@ const Trending = ({ data, query }) => { | |||
| Trending.getInitialProps = async (ctx: NextPageContext) => { | |||
| const trendingQuery = { | |||
| ...ctx.query, | |||
| ...{ minPopularity: 5, order: 'popularity' as QueryOrder }, | |||
| ...{ minPopularity: 5, minMonthlyDownloads: 250, order: 'popularity' as QueryOrder }, | |||
There was a problem hiding this comment.
i'd bump this a bit higher, maybe to 1000. 250/week is very small for a library still imo
Simek
commented
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Why & how
I have noticed that low download penalty does not work ideally after the popularity gain scoring has been tweaks, so I have decided to add a new query filter field
minMonthlyDownloadswhich will filter out the libraries with less than specified download count in last month.Additionally, I have made few a11y related tweaks and fixes.
✅ Checklist
react-native-libraries.jsonreact-native-libraries.json