Prevent DeviceInfo crash when WindowMetrics API is missing - #58077
Open
gooddev97 wants to merge 1 commit into
Open
Prevent DeviceInfo crash when WindowMetrics API is missing#58077gooddev97 wants to merge 1 commit into
gooddev97 wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #57785.
Some modified Android runtimes report API 34 or later while shipping a
WindowMetricsimplementation withoutgetDensity().WindowMetricsCalculatorthen throwsNoSuchMethodErrorwhileNativeDeviceInfoexports its constants, crashing the app before the JavaScript runtime is ready.This change catches only that missing-method failure around the window metrics lookup, reports it as a soft exception, and returns the resource display metrics that were already copied as the fallback. Normal Android runtimes continue to use the current window bounds path unchanged.
The regression test injects a
WindowMetricsCalculatorthat throws the sameNoSuchMethodErrorand verifies that resource width, height, density, and density DPI are returned. Before the production change, this test failed atDeviceInfoModule.kt:46with the uncaught error.Changelog:
[ANDROID] [FIXED] - Prevent a startup crash when the WindowMetrics API is missing on an inconsistent Android runtime
Test Plan:
JAVA_HOME=$(/usr/libexec/java_home -v 17) ./gradlew :packages:react-native:ReactAndroid:testDebugUnitTest --tests com.facebook.react.modules.deviceinfo.DeviceInfoModuleTest -Preact.internal.useHermesStable=true --no-daemon— BUILD SUCCESSFUL (8 tests)JAVA_HOME=$(/usr/libexec/java_home -v 17) ./gradlew :packages:react-native:ReactAndroid:ktfmtCheck -Preact.internal.useHermesStable=true --no-daemon --rerun-tasks— BUILD SUCCESSFULJAVA_HOME=$(/usr/libexec/java_home -v 17) ./gradlew :packages:react-native:ReactAndroid:lintDebug -Preact.internal.useHermesStable=true --no-daemon— BUILD SUCCESSFUL