Added a react on rails pro column to compare #1310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-mesnilgrente
changed the title
ahangarha
reviewed
Sep 24, 2023
Comment on lines
+819
to
+825
| | SSR with HMR | ✅ | ❌ | ✅ | | ||
| | SSR with React-Router | ❌ | ❌ | ✅ | | ||
| | SSR with Code Splitting | ❌ | ❌ | ✅ | | ||
| | Node SSR | ❌ | ❌ | ✅ | | ||
| | Advanced Redux support | ❌ | ❌ | ✅ | | ||
| | ReScript support | ❌ | ❌ | ✅ | | ||
| | I18n support | ❌ | ❌ | ✅ | |
There was a problem hiding this comment.
Are you sure about this?
In react-webpack-rails-tutorial we demonstrate many of these items use react_on_rails.
There was a problem hiding this comment.
Quoting the PR message:
I'm not sure about what's free in react-on-rails. Can you confirm the table is right?
I only guessed from what's said in the website:
There was a problem hiding this comment.
Thanks for the clarification.
An older comparison between features offered by react-rails and react_on_rails can be found on react_on_rails official docs: Shakapacker (Rails/Webpacker) React Integration Options
I close the PR for now. You can update the PR with more solid references so we can review it again.
Thanks for your PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Docs update to help with #1289 and complete #1304
I'm not sure about what's free in react-on-rails. Can you confirm the table is right?
Pull Request checklist
Add/update test to cover these changesUpdate CHANGELOG file