-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests to use new Caikit + TGIS images #1009
Update tests to use new Caikit + TGIS images #1009
Conversation
tested on |
do not merge for now, there is a new change coming into the product image and the test files need to be accordingly changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
d13455d
to
621274a
Compare
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot
Dismissed
Show dismissed
Hide dismissed
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot
Dismissed
Show dismissed
Hide dismissed
# temporarily disabling these lines - will be finalized in later stage due to a different format | ||
# of streamed reponse when using http protocol instead of grpc | ||
# ${cleaned_response_text}= Replace String Using Regexp ${model_response} data:(\\s+)?" " | ||
# ${cleaned_response_text}= Replace String Using Regexp ${cleaned_response_text} data:(\\s+)?{ { |
Check warning
Code scanning / Robocop
Trailing whitespace at the end of line Warning test
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot
Dismissed
Show dismissed
Hide dismissed
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot
Dismissed
Show dismissed
Hide dismissed
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot
Dismissed
Show dismissed
Hide dismissed
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot
Dismissed
Show dismissed
Hide dismissed
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot
Fixed
Show fixed
Hide fixed
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboardAPI.resource
Dismissed
Show dismissed
Hide dismissed
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot
Fixed
Show fixed
Hide fixed
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
PR validation:
|
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
) * update runtime and model path Signed-off-by: bdattoma <bdattoma@redhat.com> * enable script-based install as default Signed-off-by: bdattoma <bdattoma@redhat.com> * use new runtime without configs Signed-off-by: bdattoma <bdattoma@redhat.com> * restore grpc port Signed-off-by: bdattoma <bdattoma@redhat.com> * restore grpc port Signed-off-by: bdattoma <bdattoma@redhat.com> * add test for http protocol Signed-off-by: bdattoma <bdattoma@redhat.com> * change tag for runtime upgrade test Signed-off-by: bdattoma <bdattoma@redhat.com> * delete unused file Signed-off-by: bdattoma <bdattoma@redhat.com> * fix all tokens http response validation Signed-off-by: bdattoma <bdattoma@redhat.com> * add missing test teardown Signed-off-by: bdattoma <bdattoma@redhat.com> * fix post deployment test Signed-off-by: bdattoma <bdattoma@redhat.com> * fix autoscale test + restore suite setup/teardown Signed-off-by: bdattoma <bdattoma@redhat.com> * fix robocop alerts Signed-off-by: bdattoma <bdattoma@redhat.com> * fix post install test - change label Signed-off-by: bdattoma <bdattoma@redhat.com> --------- Signed-off-by: bdattoma <bdattoma@redhat.com>
) * update runtime and model path Signed-off-by: bdattoma <bdattoma@redhat.com> * enable script-based install as default Signed-off-by: bdattoma <bdattoma@redhat.com> * use new runtime without configs Signed-off-by: bdattoma <bdattoma@redhat.com> * restore grpc port Signed-off-by: bdattoma <bdattoma@redhat.com> * restore grpc port Signed-off-by: bdattoma <bdattoma@redhat.com> * add test for http protocol Signed-off-by: bdattoma <bdattoma@redhat.com> * change tag for runtime upgrade test Signed-off-by: bdattoma <bdattoma@redhat.com> * delete unused file Signed-off-by: bdattoma <bdattoma@redhat.com> * fix all tokens http response validation Signed-off-by: bdattoma <bdattoma@redhat.com> * add missing test teardown Signed-off-by: bdattoma <bdattoma@redhat.com> * fix post deployment test Signed-off-by: bdattoma <bdattoma@redhat.com> * fix autoscale test + restore suite setup/teardown Signed-off-by: bdattoma <bdattoma@redhat.com> * fix robocop alerts Signed-off-by: bdattoma <bdattoma@redhat.com> * fix post install test - change label Signed-off-by: bdattoma <bdattoma@redhat.com> --------- Signed-off-by: bdattoma <bdattoma@redhat.com>
Updating the tests to reflect the new architecture of Caikit runtime with TGIS, as implemented in opendatahub-io/caikit-tgis-serving#107: new runtime is composed by 2 separate containers, one for TGIS and one for Caikit, in the same pod.