-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Case check for correct component images #1965
base: master
Are you sure you want to change the base?
Test Case check for correct component images #1965
Conversation
|
||
|
||
*** Test Cases *** | ||
Check For Correct Component Images |
Check warning
Code scanning / Robocop
Test case '{{ test_name }}' is too long ({{ test_length }}/{{ allowed_length }}) Warning test
|
||
|
||
*** Test Cases *** | ||
Check For Correct Component Images |
Check warning
Code scanning / Robocop
Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test
[Documentation] The purpose is to enforce the check of correct component images on their deployments. | ||
[Tags] Operator RHOAIENG-12576 | ||
FOR ${cmp} IN @{COMPONENTS} | ||
${rc} ${managementState}= Run And Return Rc And Output |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
Log To Console IMAGE ON CSV IS ${csv_image} | ||
|
||
# Check for regex to see whether it is pointing mistream or downstream | ||
${rc} ${out}= Run And Return Rc And Output |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
|
||
# Check for regex to see whether it is pointing mistream or downstream | ||
${rc} ${out}= Run And Return Rc And Output | ||
... oc get Deployment ${deployment_name} -n ${APPLICATIONS_NAMESPACE} -o jsonpath='{.spec.template.spec.containers[?(@.images=="${csv_image}")]}' |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Robot Results
|
Triggered /rhods-ci-pr-test/3398 |
Check Image On Csv And Deployment | ||
... odh_notebook_controller_image | ||
... odh-notebook-controller-manager | ||
Check Image On Csv And Deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cant we do on a different way to avoid a statement per component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, robot framework has limitations on this. I was investigating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can try to have a variable to map the component name to the image name, like this:
Line 41 in 1001504
&{SAVED_MANAGEMENT_STATES} |
Quality Gate passedIssues Measures |
New Test Case to check for correct component images