Test Case check for correct component images #1965
Conversation
asanzgom
requested review from
CFSNM,
MarianMacik,
mattmahoneyrh and
jstourac
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
|
|
||
| *** Test Cases *** | ||
| Check For Correct Component Images |
Check warning
Code scanning / Robocop
Test case '{{ test_name }}' is too long ({{ test_length }}/{{ allowed_length }}) Warning test
|
|
||
|
|
||
| *** Test Cases *** | ||
| Check For Correct Component Images |
Check warning
Code scanning / Robocop
Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test
| [Documentation] The purpose is to enforce the check of correct component images on their deployments. | ||
| [Tags] Operator RHOAIENG-12576 | ||
| FOR ${cmp} IN @{COMPONENTS} | ||
| ${rc} ${managementState}= Run And Return Rc And Output |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
| Log To Console IMAGE ON CSV IS ${csv_image} | ||
|
|
||
| # Check for regex to see whether it is pointing mistream or downstream | ||
| ${rc} ${out}= Run And Return Rc And Output |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
|
|
||
| # Check for regex to see whether it is pointing mistream or downstream | ||
| ${rc} ${out}= Run And Return Rc And Output | ||
| ... oc get Deployment ${deployment_name} -n ${APPLICATIONS_NAMESPACE} -o jsonpath='{.spec.template.spec.containers[?(@.images=="${csv_image}")]}' |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Robot Results
|
|
Triggered /rhods-ci-pr-test/3398 |
| Check Image On Csv And Deployment | ||
| ... odh_notebook_controller_image | ||
| ... odh-notebook-controller-manager | ||
| Check Image On Csv And Deployment |
There was a problem hiding this comment.
cant we do on a different way to avoid a statement per component?
There was a problem hiding this comment.
No, robot framework has limitations on this. I was investigating
There was a problem hiding this comment.
we can try to have a variable to map the component name to the image name, like this:
|
New Test Case to check for correct component images