feat(intelligent-assistant): accept WebP image attachments on /v1/query - #4512
Open
JslYoon wants to merge 2 commits into
Open
feat(intelligent-assistant): accept WebP image attachments on /v1/query#4512JslYoon wants to merge 2 commits into
JslYoon wants to merge 2 commits into
Conversation
Add WebP (image/webp) as a supported filetype for screen context attachments, alongside the existing JPEG support. Images are validated by magic bytes: WebP files are a RIFF container with "RIFF" at offset 0 and "WEBP" at offset 8. Updates the vision-unsupported error message to be filetype-agnostic and adds unit and end-to-end tests covering WebP accept, data-URL WebP, and invalid magic-byte rejection. Requires WebP support on the lightspeed-stack /query route (lightspeed-core/lightspeed-stack#2556). Assisted-by: Claude Opus 4.8 Signed-off-by: Lucas <lyoon@redhat.com>
JslYoon
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
September 1, 2026 08:34
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Contributor
Author
|
/s-review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4512 +/- ##
==========================================
- Coverage 61.81% 61.79% -0.03%
==========================================
Files 2587 2583 -4
Lines 103335 103253 -82
Branches 29014 28926 -88
==========================================
- Hits 63875 63801 -74
- Misses 37601 38897 +1296
+ Partials 1859 555 -1304
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
New changes are detected. LGTM label has been removed. |
|
Contributor
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 2:09 PM UTC · Completed 2:23 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $4.75 |
ReviewFindingsLow
Labels: PR adds a feature to the intelligent-assistant workspace. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
|
|
||
| function hasValidJpegMagicBytes(content: string): boolean { | ||
| const bytes = Buffer.from(extractBase64(content), 'base64'); | ||
| function matchesMagic(bytes: Buffer, magic: number[], offset = 0): boolean { |
There was a problem hiding this comment.
[low] naming convention
The new matchesMagic helper function returns a boolean but does not follow the has*/is* prefix convention established by the other boolean-returning private functions in the same file (hasValidImageMagicBytes, isValidJson).
Suggested fix: Consider renaming to hasMagicBytes or isMagicMatch.
fullsend-ai-review
Bot
added
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds WebP (
image/webp) as a supported filetype for screen context attachments on the/v1/queryroute, alongside the existing JPEG support.Image attachments are validated by their magic bytes. WebP files are a RIFF container —
RIFFat offset 0 andWEBPat offset 8 — so both markers are checked. JPEG validation is unchanged.The vision-unsupported error message is updated to be filetype-agnostic (
does not support image attachments) now that more than one image type is accepted.Changes
validation.ts— accept WebP magic bytes alongside JPEG (hasValidImageMagicBytes); update error messages.validation.test.ts— unit tests for WebP accept (raw + data URL) and updated reject message.router.test.ts— end-to-end/v1/querytests for WebP accept and invalid magic-byte rejection.Testing
yarn test— 107 passing across the two suites.RIFF...WEBP VP8), run through the actualvalidateAttachmentsForModelmiddleware: real WebP and data-URL WebP accepted; truncated RIFF rejected.Related
Depends on WebP support on the lightspeed-stack
/queryroute: lightspeed-core/lightspeed-stack#2556.🤖 Generated with Claude Code