(RHEL-30372) efi: check if all sections of our EFI binaries are properly aligned #248
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tracker/missing
Commit validationTracker - RHEL-30372 The following commits meet all requirements
Tracker validationFailed🔴 Tracker RHEL-30372 is missing severity Success🟢 Tracker RHEL-30372 has set desired product: Pull Request validationFailed🔴 Failed or pending checks - Success🟢 Review - Reviewed by a member |
jamacku
reviewed
Mar 26, 2024
mrc0mmand
force-pushed
the
efi-check-alignment
branch
from
f4376e8
to
bdcac04
Compare
|
Updated the references and marked for review, even though it'll keep failing until the undrelying objcopy issue is fixed (should be in 9.5, although that won't help us in GH Actions CI which run Ubuntu, so this'll get interesting). Also, it's very possible we might ditch the gnu-efi+objcopy approach completely in the meanwhile due to https://issues.redhat.com/browse/RHEL-30400. |
github-actions
bot
changed the title
msekletar
approved these changes
Jun 11, 2024
(cherry picked from commit 7ff3b88) Related: RHEL-30372
(cherry picked from commit 1f6da5d) Related: RHEL-30372
Otherwise, when building with ukify disabled, no one else requires pefile, and
if it is not installed, those tests fail:
```
================================== 12/1212 ===================================
test: systemd:efi / check-alignment-systemd-bootx64.efi
start time: 14:21:54
duration: 0.08s
result: exit status 1
command: /mnt/work/systemd/upstream-fork/main/tools/check-efi-alignment.py /mnt/work/systemd/upstream-fork/main/build/src/boot/efi/systemd-bootx64.efi
----------------------------------- stderr -----------------------------------
Traceback (most recent call last):
File "/mnt/work/systemd/upstream-fork/main/tools/check-efi-alignment.py", line 7, in <module>
import pefile
ModuleNotFoundError: No module named 'pefile'
==============================================================================
================================== 13/1212 ===================================
test: systemd:efi / check-alignment-linuxx64.efi.stub
start time: 14:21:54
duration: 0.08s
result: exit status 1
command: /mnt/work/systemd/upstream-fork/main/tools/check-efi-alignment.py /mnt/work/systemd/upstream-fork/main/build/src/boot/efi/linuxx64.efi.stub
----------------------------------- stderr -----------------------------------
Traceback (most recent call last):
File "/mnt/work/systemd/upstream-fork/main/tools/check-efi-alignment.py", line 7, in <module>
import pefile
ModuleNotFoundError: No module named 'pefile'
==============================================================================
================================== 14/1212 ===================================
test: systemd:efi / check-alignment-addonx64.efi.stub
start time: 14:21:54
duration: 0.07s
result: exit status 1
command: /mnt/work/systemd/upstream-fork/main/tools/check-efi-alignment.py /mnt/work/systemd/upstream-fork/main/build/src/boot/efi/addonx64.efi.stub
----------------------------------- stderr -----------------------------------
Traceback (most recent call last):
File "/mnt/work/systemd/upstream-fork/main/tools/check-efi-alignment.py", line 7, in <module>
import pefile
ModuleNotFoundError: No module named 'pefile'
==============================================================================
```
Follow-up for 7ff3b88
(cherry picked from commit f0896ca)
Related: RHEL-30372
jamacku
force-pushed
the
efi-check-alignment
branch
from
874af04
to
1abe8dc
Compare
github-actions
bot
added
tracker/missing
github-actions
bot
added
tracker/missing
github-actions
bot
added
tracker/missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 7ff3b88)
Related: TBD