(RHEL-55301) Don't GC unit if it is in another queue #299
+89
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gc_unit_queue is dispatched before the cgroup_empty_queue. Because of this, when we enter in on_cgroup_empty_event, the unit in cgroup_empty_queue may already have been freed and we don't clean up the corresponding cgroup. With this change, we prevent the unit from being garbage collected if it is in the cgroup_empty_queue. (cherry picked from commit 8db9989) Resolves: RHEL-55301
This change removes the pruning of cgroups for FAILED/INACTIVE units from per-unit-type handlers and moves it in on_cgroup_empty_event. (cherry picked from commit 380dd17) Related: RHEL-55301
In test-execute, only the unit was started, not the slice. Because of that the slice cgroup was pruned even if it was still needed. From what I can tell, this is because, in the test, we don't have all the mechanics that starts the slice for a service. To fix the issue the slice is started manually. (cherry picked from commit fc6172b) Related: RHEL-55301
Let's make sure that D-Bus messages are always sent out when pending, before we might GC a unit/job. This is kinda a follow-up for 8db9989, and a similar logic really applies: GC should only be done if we processed everything else, generated evertyhing else and really don't need it anymore. (cherry picked from commit af05bb9) Related: RHEL-55301
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| set -o pipefail | ||
|
|
||
| # shellcheck source=test/units/util.sh | ||
| . "$(dirname "$0")"/util.sh |
Check notice
Code scanning / shellcheck
Not following: test/units/util.sh: openBinaryFile: does not exist (No such file or directory) Note test
github-actions
bot
changed the title
github-actions
bot
added
tracker/unapproved
Commit validationTracker - RHEL-55301 The following commits meet all requirements
Tracker validationFailed🔴 Tracker RHEL-55301 is missing severity Success🟢 Tracker RHEL-55301 has set desired product: Pull Request validationFailed🔴 Failed or pending checks - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: RHEL-55301