Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CI to latest redis versions #163

Merged
merged 24 commits into from
Aug 14, 2023
Merged

Updating CI to latest redis versions #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
a765325
Redis version bump for testing
chayim Jul 31, 2023
bf875f4
change RC to Uppercase
shacharPash Aug 1, 2023
0ca132d
Merge branch 'master' into ck-redisverisons
shacharPash Aug 2, 2023
80be48b
skip graph tests if version is 7.2.0-RC3
shacharPash Aug 6, 2023
5eaf425
delete new traits
shacharPash Aug 6, 2023
8196154
else if => elif
shacharPash Aug 6, 2023
d9547e3
elif => if
shacharPash Aug 6, 2023
1159216
elif
shacharPash Aug 6, 2023
3a64860
Try somthing
shacharPash Aug 6, 2023
ae0fdbd
try
shacharPash Aug 6, 2023
77276d7
try to fix contitions
shacharPash Aug 6, 2023
96dde55
lessSkipAttr
shacharPash Aug 8, 2023
e272e58
WIP
shacharPash Aug 8, 2023
ce6d900
Try to use SkipIfRedisVersionLt Attribute
shacharPash Aug 9, 2023
826afe6
go back
shacharPash Aug 9, 2023
4e149b2
fixes of places with graph
shacharPash Aug 9, 2023
61dd8da
change to SkipIfRedisVersionGte("7.2.0-RC3")
shacharPash Aug 9, 2023
50310ae
try diif version
shacharPash Aug 9, 2023
4be090d
try very small version to check if skip
shacharPash Aug 10, 2023
d0f9573
change version to 7.1.242
shacharPash Aug 10, 2023
5496d02
Delete trait
shacharPash Aug 10, 2023
c69951c
Merge branch 'master' into ck-redisverisons
shacharPash Aug 10, 2023
6b38f84
one SkipIfRedisVersionAttribute
shacharPash Aug 13, 2023
b99dc71
fix error
shacharPash Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
fail-fast: false
matrix:
redis-stack-version: ["6.2.6-v7", "7.0.6-RC8", "edge"]
redis-stack-version: ["6.2.6-v9", "7.2.0-RC3", "edge"]
shacharPash marked this conversation as resolved.
Show resolved Hide resolved
env:
USER_NAME: ${{ secrets.USER_NAME }}
PASSWORD: ${{ secrets.PASSWORD }}
Expand Down Expand Up @@ -46,22 +46,14 @@ jobs:
echo "${{secrets.REDIS_USER_CRT}}" > tests/NRedisStack.Tests/bin/Debug/net6.0/redis_user.crt
echo "${{secrets.REDIS_USER_PRIVATE_KEY}}" > tests/NRedisStack.Tests/bin/Debug/net6.0/redis_user_private.key
ls -R
if [ "$REDIS_VERSION" != "edge" ]; then
dotnet test -f net6.0 --no-build --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat=opencover --filter Category!=edge
else
dotnet test -f net6.0 --no-build --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat=opencover
fi
dotnet test -f net6.0 --no-build --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat=opencover
- name: Test
run: |
echo "${{secrets.REDIS_CA_PEM}}" > tests/NRedisStack.Tests/bin/Debug/net7.0/redis_ca.pem
echo "${{secrets.REDIS_USER_CRT}}" > tests/NRedisStack.Tests/bin/Debug/net7.0/redis_user.crt
echo "${{secrets.REDIS_USER_PRIVATE_KEY}}" > tests/NRedisStack.Tests/bin/Debug/net7.0/redis_user_private.key
ls -R
if [ "$REDIS_VERSION" != "edge" ]; then
dotnet test -f net7.0 --no-build --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat=opencover --filter Category!=edge
else
dotnet test -f net7.0 --no-build --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat=opencover
fi
dotnet test -f net7.0 --no-build --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat=opencover
- name: Codecov
uses: codecov/codecov-action@v3
with:
Expand Down Expand Up @@ -105,4 +97,4 @@ jobs:
shell: cmd
run: |
START wsl ./redis-stack-server-${{env.redis_stack_version}}/bin/redis-stack-server &
dotnet test -f net481 --no-build --verbosity normal --filter Category!=edge
dotnet test -f net481 --no-build --verbosity normal
21 changes: 7 additions & 14 deletions tests/NRedisStack.Tests/Gears/GearsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ public void Dispose()
}


[Fact]
[Trait("Category", "edge")]
[SkipIfRedisVersion(Comparison.LessThan, "7.1.242")]
public void TestTFunctionLoadDelete()
{
IDatabase db = redisFixture.Redis.GetDatabase();
Expand All @@ -27,8 +26,7 @@ public void TestTFunctionLoadDelete()
}


[Fact]
[Trait("Category", "edge")]
[SkipIfRedisVersion(Comparison.LessThan, "7.1.242")]
public async Task TestTFunctionLoadDeleteAsync()
{
IDatabase db = redisFixture.Redis.GetDatabase();
Expand All @@ -39,8 +37,7 @@ public async Task TestTFunctionLoadDeleteAsync()
Assert.True(await db.TFunctionDeleteAsync("lib"));
}

[Fact]
[Trait("Category", "edge")]
[SkipIfRedisVersion(Comparison.LessThan, "7.1.242")]
public void TestTFunctionList()
{
IDatabase db = redisFixture.Redis.GetDatabase();
Expand Down Expand Up @@ -71,8 +68,7 @@ public void TestTFunctionList()
Assert.True(db.TFunctionDelete("lib3"));
}

[Fact]
[Trait("Category", "edge")]
[SkipIfRedisVersion(Comparison.LessThan, "7.1.242")]
public async Task TestTFunctionListAsync()
{
IDatabase db = redisFixture.Redis.GetDatabase();
Expand Down Expand Up @@ -101,8 +97,7 @@ public async Task TestTFunctionListAsync()
Assert.True(await db.TFunctionDeleteAsync("lib3"));
}

[Fact]
[Trait("Category", "edge")]
[SkipIfRedisVersion(Comparison.LessThan, "7.1.242")]
public void TestTFCall()
{
IDatabase db = redisFixture.Redis.GetDatabase();
Expand All @@ -116,8 +111,7 @@ public void TestTFCall()
Assert.True(db.TFunctionDelete("lib"));
}

[Fact]
[Trait("Category", "edge")]
[SkipIfRedisVersion(Comparison.LessThan, "7.1.242")]
public async Task TestTFCallAsync()
{
IDatabase db = redisFixture.Redis.GetDatabase();
Expand All @@ -131,8 +125,7 @@ public async Task TestTFCallAsync()
Assert.True(await db.TFunctionDeleteAsync("lib"));
}

[Fact]
[Trait("Category", "edge")]
[SkipIfRedisVersion(Comparison.LessThan, "7.1.242")]
public void TestGearsCommandBuilder()
{
// TFunctionLoad:
Expand Down
Loading
Loading