-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-4295 added aggregate query examples #341
DOC-4295 added aggregate query examples #341
Conversation
// STEP_START agg4 | ||
|
||
// Not supported in NRedisStack. | ||
|
||
// STEP_END |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you share the code fragment you tried?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atakavci I've added it after // STEP_START agg4
as a separate commit. It basically just doesn't include the list of bicycles that were supposed to come from the ToList reducer. The Row object doesn't even seem to have an element for the bicycles list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andy-stark-redis you are right !! we have a bug with getting list of items with result.
To share more context, return type does not provide a way to contain a list of items as of now (it is a Dictionary<string, RedisValue>). We might need to introduce a breaking change to fix this.
Would you mind opening an issue for this? i ll pick it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atakavci I've added this issue. I've replaced the dodgy code with the original missing example message. I'll edit the issue to add a link to the source file once this PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! thanks..
// STEP_START agg4 | ||
|
||
// Not supported in NRedisStack. | ||
|
||
// STEP_END |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! thanks..
These examples don't yet have equivalents in the published docs for other languages but this PR includes the Markdown for the tabs that will appear in this page.
Note that the last example just contains a comment saying
Not supported in NRedisStack
. The code didn't work when I tried it, which I believe is a result of this open issue with NRedisStack.