-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refresh connection for pipeline when getting JedisMovedDataException #3699
base: master
Are you sure you want to change the base?
Conversation
should get connection first and then create new pipeline queue, otherwise it would cause NPE when timeout for getting connection and call sync() method
pipelinedResponses should be clear in MultiNodePipelineBase.java and avoid this pipeline object reporting ENP when executing close() and reuse
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3699 +/- ##
=========================================
Coverage 75.64% 75.65%
- Complexity 4914 4915 +1
=========================================
Files 297 297
Lines 14956 14957 +1
Branches 1124 1124
=========================================
+ Hits 11314 11316 +2
Misses 3149 3149
+ Partials 493 492 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stillerrr What about inner Queue
s in pipelinedResponses?
I think it would be okay, the queue would be empty after executing sync(), but pipelinedResponses also has the empty queue once the pipeline object is reused, there is no connection in connnections map, but has queue in pipelinedResponses map |
@sazzad16 add method to refresh connection for pipeline when getting JedisMovedDataException |
@sazzad16 PTAL |
pipelinedResponses should be clear in MultiNodePipelineBase.java and avoid this pipeline object reporting ENP when executing close() and reuse like #3697
MultiNodePipelineBase can be reused when calling close(), there is no switch to avoid this way to use MultiNodePipelineBase