Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve QueryRangeExample and QueryGeoExample #3970

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Improve QueryRangeExample and QueryGeoExample #3970

merged 2 commits into from
Sep 27, 2024

Conversation

uglide
Copy link
Contributor

@uglide uglide commented Sep 27, 2024

  • Do not rely on random order of unsorted search results
  • Print prices for clarity

@uglide
Improve QueryRangeExample
2088bf7 
- Do not rely on random order of unsorted search results
- Print prices for clarity
@uglide
Copy link
Contributor Author

uglide commented Sep 27, 2024

@andy-stark-redis, I improved your example by removing the flakiness of assertions and printing prices.

@uglide uglide changed the title Improve QueryRangeExample Improve QueryRangeExample and QueryGeoExample Sep 27, 2024
@uglide uglide merged commit d22df4b into master Sep 27, 2024
4 checks passed
@uglide uglide deleted the improve_query_range_doctest branch September 27, 2024 12:20
@andy-stark-redis
Copy link
Contributor

@andy-stark-redis, I improved your example by removing the flakiness of assertions and printing prices.

That's great, thanks! I didn't know about Stream.of until now but I'll use that technique for assertions like this in the future.

@sazzad16
Copy link
Collaborator

@andy-stark-redis The trick is more in .sorted(), IMO 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uglide @andy-stark-redis @sazzad16