Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize an mkdocs-based Jedis doc site #3998

Closed
wants to merge 12 commits into from

Conversation

joshrotenberg
Copy link
Contributor

This PR unifies the current content in docs and the Wiki into a single, GitHub pages hosted Jedis documentation portal. So far it's a minimal effort combo of the two plus a few extra links, with the intent that it can continue to grow into a single point of reference for all things Jedis. For the most part it mirrors the lettuce implementation in spirit.

If merged, Pages will also need to be enabled for the repo. Go to Settings, Pages in the left hand navigation, and select GitHub Actions in the Build and deployment dropdown.

My fork has an up to date version running here as an example: https://joshrotenberg.com/jedis/

@sazzad16 sazzad16 requested a review from uglide October 18, 2024 04:43
@sazzad16 sazzad16 changed the title Initialize an mkdocs-baseed Jedis doc site. Initialize an mkdocs-based Jedis doc site Oct 20, 2024
@uglide
Copy link
Contributor

uglide commented Oct 21, 2024

@joshrotenberg Thanks for working on this!

Copy link
Contributor

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! One small note about the getting-started page. Once fixed, we can merge it and finally deprecate outdated wiki content.

docs/getting-started.md Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub home page contains a link to this file. If we remove this file, we should also change the link in README.md in root folder.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be ignored from spell check.

@@ -0,0 +1,15 @@
# Jedis Documentation

This documenation uses [MkDocs](https://www.mkdocs.org/) to generate the static site.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documenation


See [mkdocs.yml](../mkdocs.yml) for the configuration.

To develop the documentation locally, you can use the included [Dockefile](ockerfile) to build a container with all the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockefile
and its link

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be ignored from spell check.

@uglide uglide closed this Oct 22, 2024
@uglide uglide mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants