-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support: stream, v12, -fvisibility, CI 5.0 6.0 6.2, make debug. Fix json enc #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
tezc
reviewed
Oct 8, 2023
oranagra
reviewed
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skimmed through it (skipped the tests as usual, other than a quick look at json and resp output).
took a few minor comments.
oranagra
reviewed
Oct 12, 2023
moticless
changed the title
Stream support
Stream support; hide symbols; Test vs. Redis 5.0,6.0,6.2; make debug
Oct 15, 2023
oranagra
reviewed
Oct 15, 2023
moticless
changed the title
Stream support; hide symbols; Test vs. Redis 5.0,6.0,6.2; make debug
Stream support; hide symbols; CI 5.0,6.0,6.2,unstable; make debug; Fix json enc
Oct 15, 2023
moticless
changed the title
Stream support; hide symbols; CI 5.0,6.0,6.2,unstable; make debug; Fix json enc
Stream support; hide symbols; CI 5.0,6.0,6.2,latest; make debug; Fix json enc
Oct 15, 2023
moticless
changed the title
Stream support; hide symbols; CI 5.0,6.0,6.2,latest; make debug; Fix json enc
Support: stream, v12, -fvisibility, CI 5.0 6.0 6.2, make debug. Fix json enc
Oct 16, 2023
oranagra
reviewed
Oct 16, 2023
oranagra
reviewed
Oct 17, 2023
oranagra
approved these changes
Oct 18, 2023
tezc
reviewed
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream support
Make "-fvisibility=hidden
Set the default visibility of symbols to be hidden.
This raises an issue with
deps/redis
files because it is currently beingbuild internally and staticaly linked with librdb.so whereas librdb-ext.so need it
as well for few APIs, such as the use of the rax data structure or CRC.
Instead of refactoring and creating an additional shared library, or making
copies for each library (with all the associated implications) we shall expose
specific symbols from librdb.so that are needed by librdb-ext.so. These symbols
won't be documented in the API, but they will be available for use. Since we
compile by default with hidden visibility, we need to mark them explicitly as
visible using the following macro inside
deps/redis
:While it might initially seem cumbersome to manually designate each function as
visible, this approach has its benefits. By carefully selecting the functions
to expose, we are encouraged to contemplate what we are exposing and why.
Moreover, it helps prevent the cluttering clients of librdb with unnecessary
symbols.
List of all symbols (All Undefined symbols were filtered-out. Functions of standard libraries):