RESP2REDIS: Refine error reporting from server #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tezc
reviewed
Oct 23, 2023
tezc
reviewed
Oct 23, 2023
tezc
reviewed
Oct 23, 2023
oranagra
previously requested changes
Oct 26, 2023
tezc
reviewed
Oct 26, 2023
tezc
reviewed
Oct 26, 2023
tezc
reviewed
Oct 26, 2023
tezc
previously approved these changes
Oct 26, 2023
tezc
approved these changes
Oct 26, 2023
moticless
dismissed
oranagra’s stale review
Marked review as resolved. Not sure why it still blocking me to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api of RESP writer (which attached to RDB2RESP) is rather simple as it expects a plain iovec. This API is not sufficient when it comes to play the RESP against live server such as the case of respToRedisLoader. In case of an error from the server it is desired to report an informative message to the user of the problematic command and key. librdb does have mechanism to report on the problematic command even in case of pipeline of commands but it reports the entire command as a raw data with not distinction down to command and key.
(Another motivation to this change is to be aligned with RE Syncer code that expects specific formatted errors)