Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new "transform arguments" API for better key and metadata extraction #2733

Merged
merged 8 commits into from
Oct 31, 2024
Merged

new "transform arguments" API for better key and metadata extraction #2733

merged 8 commits into from
Oct 31, 2024

Commits on Oct 15, 2024

  1. Parser support with all commands

    @sjpotter
    sjpotter committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c39f377 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. remove "dist" from all imports for consistency

    @sjpotter
    sjpotter committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    6e7a558 View commit details
    Browse the repository at this point in the history

  2. address most of my review comments

    @sjpotter
    sjpotter committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    5bc06e0 View commit details
    Browse the repository at this point in the history

  3. small tweak to multi type mapping handling

    @sjpotter
    sjpotter committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    4c08d83 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. tweak multi commands / fix addScript cases

    @sjpotter
    sjpotter committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    03c2be0 View commit details
    Browse the repository at this point in the history

  2. nits

    @sjpotter
    sjpotter committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    21ce0cb View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. addressed all in person review comments

    @sjpotter
    sjpotter committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c1d69ae View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. revert addCommand/addScript changes to multi-commands 

    addCommand needs to be there for sendCommand like ability within a multi.

If its there, it might as well be used by createCommand() et al, to avoid repeating code.

addScript is there (even though only used once), but now made private to keep the logic for bookkeeping near each other.
    @sjpotter
    sjpotter committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7f52e7c View commit details
    Browse the repository at this point in the history