Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSCAN NOVALUES support (v5) #2758

Merged
merged 3 commits into from
Jun 3, 2024
Merged

HSCAN NOVALUES support (v5) #2758

merged 3 commits into from
Jun 3, 2024

Conversation

sjpotter
Copy link
Contributor

Description

Describe your pull request here

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@sjpotter sjpotter requested a review from leibale May 15, 2024 10:49
leibale
leibale requested changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@leibale leibale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add support for RedisClient/RedisCluster/RedisSentinel.hScanValuesIterator too please

@leibale
Copy link
Collaborator

leibale commented May 16, 2024

duplicate of #2711

@sjpotter sjpotter changed the title HSCAN VALUES support (v5) HSCAN NOVALUES support (v5) Jun 2, 2024
@sjpotter
Copy link
Contributor Author

sjpotter commented Jun 2, 2024

added iterator support on RedisClient type, don't see any iterator on any of the other clients, should we add them all there as well?

@leibale
Copy link
Collaborator

leibale commented Jun 3, 2024 •
edited
Loading

@sjpotter support for async iterators in cluster should be part of #2657

@leibale leibale merged commit 271baf3 into redis:v5 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leibale leibale leibale requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpotter @leibale